Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Create service account after helm install #432

Closed
work82mj opened this issue Oct 16, 2023 · 1 comment · Fixed by #476
Closed

[Bug] Create service account after helm install #432

work82mj opened this issue Oct 16, 2023 · 1 comment · Fixed by #476
Labels
bug Something isn't working

Comments

@work82mj
Copy link

work82mj commented Oct 16, 2023

What are you really trying to do?

Create service account using command helm upgrade

helm upgrade --set server.replicaCount=1 --install temporal-dev . --values values-dev.yaml -n dev --set serviceAccount.create=true

Describe the bug

Error: UPGRADE FAILED: pre-upgrade hooks failed: timed out waiting for the condition

Minimal Reproduction

using default values of serviceaccount.yaml

Environment/Versions

  • Temporal Version: 2.16.2(on my web) & temporalio == 1.3.0
  • Kubernetes: v1.25.12 (EKS)

Additional context

add pre-upgrade to annotations in serviceaccount.yaml

{{- if .Values.serviceAccount.create -}}
apiVersion: v1
kind: ServiceAccount
metadata:
  name: {{ include "temporal.serviceAccountName" . }}
  labels:
    app.kubernetes.io/name: {{ include "temporal.name" . }}
    helm.sh/chart: {{ include "temporal.chart". }}
    app.kubernetes.io/managed-by: {{ .Release.Service }}
    app.kubernetes.io/instance: {{ .Release.Name }}
    app.kubernetes.io/version: {{ .Chart.AppVersion | replace "+" "_" }}
    app.kubernetes.io/part-of: {{ .Chart.Name }}
  annotations:
    helm.sh/hook: pre-install, pre-upgrade
    helm.sh/hook-weight: "-10"
    {{- with .Values.serviceAccount.extraAnnotations }}
      {{- toYaml . | nindent 4 }}
    {{- end }}
{{- end -}}
@work82mj work82mj added the bug Something isn't working label Oct 16, 2023
@punit-kulal
Copy link
Contributor

Encountered the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants