Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in Development.md #1916

Closed
wants to merge 1 commit into from
Closed

Fix broken link in Development.md #1916

wants to merge 1 commit into from

Conversation

SD-13
Copy link

@SD-13 SD-13 commented Jan 1, 2024 •
edited

Changes

Fix #1914
Fix a broken link in Development.md.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign concaf after the PR has been reviewed.
You can assign the PR to them by writing /assign @concaf in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 1, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 1, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SD-13 / name: Sujay (99d74db)

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 1, 2024
@tekton-robot
Copy link
Contributor

Hi @SD-13. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 1, 2024
@piyush-garg
Copy link
Contributor

piyush-garg commented Jan 5, 2024 •
edited

Hey @SD-13

We have now moved to kind in our CI, and can you please also update doc to setup up kind cluster instead of GKE one.

cc @vdemeester @jkandasa

@SD-13
Copy link
Author

SD-13 commented Jan 5, 2024

Hey @SD-13

We have now moved to kind in our CI, and can you please also update doc to setup up kind cluster instead of GKE one.

cc @vdemeester @jkandasa

Sure!

@SD-13
Copy link
Author

SD-13 commented Feb 9, 2024

Sorry, I lost track of it. I am starting to work on the suggested changes :)

@jkandasa
Copy link
Member

jkandasa commented Jun 6, 2024

/close
Please raise a new PR, if you still want to change this.

@jkandasa jkandasa closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link broken on tektoncd/operator/blob/main/DEVELOPMENT.md
4 participants
@SD-13 @tekton-robot @piyush-garg @jkandasa