Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme, troubleshooting, or play should ensure metal_lb_ip_range and apiserver_endpoint have valid ips in flannel_iface #377

Open
edoziw opened this issue Oct 5, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@edoziw
Copy link

edoziw commented Oct 5, 2023

RE: closed issue

Expected Behavior

Document and or assert metal_lb_ip_range and apiserver_endpoint have valid ips in flannel_iface

Current Behavior

If the master and or node hosts flannel_iface eg eth0 has a netmask of 255.255.255.0 and an ip of 192.168.0.*
vars of

  • apiserver_endpoint: "192.168.30.222"
  • metal_lb_ip_range: "192.168.30.80-192.168.30.90"

are invalid

Steps to Reproduce

given

docs, but use invalid ips like above

when

ansible-playbook site.yml

then

docs and or trouble shooting or assert should explain the problem

Possible Solution

  • the site.yml or one of its roles could assert
    • that the ips are in the correct range for masters and nodes
  • the doc could mention this
  • troubleshooting could mention this

Thanks

@edoziw
Copy link
Author

edoziw commented Oct 5, 2023

Tim, if you find this reasonable I'd be happy to give a PR or PRs a go..
possible PRs:

  • doc
  • troubleshooting
  • assert in a role or play

@timothystewart6
Copy link
Contributor

timothystewart6 commented Oct 8, 2023

This would be awesome! If you are going to do that work, another thing to assert is that the apiserver_endpoint does not fall into the range of the metal_lb_ip_range . That seems to be another common pitfall.

@edoziw
Copy link
Author

edoziw commented Oct 19, 2023

PR pushed
thanks Tim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants