-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from deprecated master role #339
Labels
good first issue
Good for newcomers
Comments
6 tasks
Same issue with hardcoded names "master" in the roles. |
@twistedgrim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be nice to move to the newer control plane taints on nodes that are used as control plane nodes. As people use the playbook and charts and apps rely on the control plane taint more than a master taint it will start to cause issues. More info below.
Migrate from the old deprecated master taint to the new control-plane taint.
Kubernetes docs from 1.20 show this change.
The label applied to control-plane nodes "node-role.kubernetes.io/master" is now deprecated and will be removed in a future release after a GA deprecation period.
Introduce a new label "node-role.kubernetes.io/control-plane" that will be applied in parallel to "node-role.kubernetes.io/master" until the removal of the "node-role.kubernetes.io/master" label.
Make "kubeadm upgrade apply" add the "node-role.kubernetes.io/control-plane" label on existing nodes that only have the "node-role.kubernetes.io/master" label during upgrade.
Please adapt your tooling built on top of kubeadm to use the "node-role.kubernetes.io/control-plane" label.
The taint applied to control-plane nodes "node-role.kubernetes.io/master:NoSchedule" is now deprecated and will be removed in a future release after a GA deprecation period.
Apply toleration for a new, future taint "node-role.kubernetes.io/control-plane:NoSchedule" to the kubeadm CoreDNS / kube-dns managed manifests. Note that this taint is not yet applied to kubeadm control-plane nodes.
The text was updated successfully, but these errors were encountered: