Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<a> tag optimization #143

Open
MaximilianoCabreraP opened this issue Oct 17, 2023 · 4 comments
Open

<a> tag optimization #143

MaximilianoCabreraP opened this issue Oct 17, 2023 · 4 comments

Comments

@MaximilianoCabreraP
Copy link

I want to fix the tag and apply it to the entire container

@ashish-gopalika
Copy link
Member

@MaximilianoCabreraP give the better explanation of exactly what you want to do by reflecting the differences between existing behaviour and expected behaviour
Add the screenshots as well if possible

@MaximilianoCabreraP
Copy link
Author

MaximilianoCabreraP commented Oct 19, 2023

Sorry, you're right, but now I see the code has changed, what I suggest is that the entire card has the option to function as an anchor and not transform the pointer, since it only redirects if you click on the github button

I attach an image of the only point where the redirect acts
image

I take this opportunity to ask, would you prefer that I create the issue or create the PR directly?

@ashish-gopalika
Copy link
Member

@MaximilianoCabreraP what I can understand is that you are suggesting that the cursor should only changes while hovering over github button and not on the entire container.
Right??

@MaximilianoCabreraP
Copy link
Author

mm I suggest all cards have tag, it will be easier for users to click on it.

I can do the PR and if you see it ok, you can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants