-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for Object.groupBy
/ Map.groupBy
with strings?
#4036
Comments
Sounds great. I'd hope basically all implementation bugs end up with test262 regression tests :-) |
Thank you, I will try to submit a PR. |
Following up from #4038, I think it might help to have additional coverage for ASCII strings (to help debuggability in case an implementation gets single characters right but surrogate pairs wrong) and grapheme clusters (like 👨👦 being split into 👨, ZWJ, and 👦.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Object.groupBy
andMap.groupBy
take an iterable, such as an array, as their first argument. This can be any iterable, so they can also accept a string.However, it was discovered that in some implementations, a TypeError was thrown when the first argument was not of object type, so this was not working1.
What do you think about adding test cases to test262 to cover this?
Footnotes
https://bugs.webkit.org/show_bug.cgi?id=271524 ↩
The text was updated successfully, but these errors were encountered: