-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to detect Python projects that don't have a .py
file in their root
#105
Labels
bug
Something isn't working
Comments
Hmm, That's interesting, thank you for the context, I haven't done python in quite a while. I have been working on a rework which allows easier use of more complicated project detection logic so this is a great example of what it would need to support. |
For the record, ALE (a Vim LSP plugin) detects Python project roots as described here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears that kondo (as of commit 69c153b) detects Python projects by looking for a file with a
.py
extension, at which point the directory in which this file is located is taken as the project root. However, this easily results in false negatives for modern Python packages, in which directories that need cleaning can be located above the directory of.py
files.Note the following about Python projects:
setup.py
file (historical and now somewhat discouraged, but there's a lot of history),setup.cfg
(declarative form ofsetup.py
that was recommended for a while), and/orpyproject.toml
file (new standard) in the project root.setup.py
/setup.cfg
/pyproject.toml
. If all are absent, the most reliable marker for a project root is probably arequirements.txt
file, but this is purely conventional.tox.ini
ornoxfile.py
..py
files tend to be organized under a directory with the same or similar name to that of the project. This directory is either located in the project root or nested inside asrc/
directory in the project root (though, in the latter case, I'd expect such projects to also be the kind to have asetup.py
,setup.cfg
, orpyproject.toml
file)..py
files to be located inside one or more levels of otherwise-empty non-src/
directories, though I think it'd be highly unusual to do this if you weren't planning on distributing the project.The text was updated successfully, but these errors were encountered: