[BUG] MetaPhlAn 4 output with duplicate clade tax id is not supported #140
Comments
|
Thank you for the detailed report. It is somewhat curious that the names of the species are distinguished by a letter suffix, but the numeric identifier is the same... And no identifiers for the strains at all. I will look into it but I'm actually not sure what the correct solution should be. |
|
@MajoroMask, the only solution that I can see immediately, is to sum up the relative abundances for the same taxon identifier. This would mean all relative abundances for the species are added together, while the strains would be added to unclassified as there is no identifier. Not really ideal. Can you think of a better solution? |
|
I have same error by metaphlan,how to slove it?
|
@Midnighter I got no idea... can author of MetaPhlAn 4 be reached? Maybe they have a solution for generating an ID to the output. |
|
another ex if it helps: |
|
@d-callan thank you for the additional data. Do you have any thoughts on the following? I'm not clear on how to solve this at the moment.
|
|
@Midnighter I think that's as reasonable as anything.. if I want strains from biobakery tools I'd look to strainphlan rather than metaphlan. It's possible a warning would be good, or maybe making the behavior configurable. |
|
@Midnighter im also wondering if you have a sense for what this would take in terms of effort? i am very interested in getting this working, and would be willing to put effort to it if you wanted. |
|
I think, code change is minimal. 2-3 lines. Will need an extra test case or so. |
|
this one i think is fun |
|
Sorry for randomly jumping in here, but I have used MetaPhlAn a fair bit. The clade tax id values come from NCBI, but the taxa/clade name are coming from their own clustering/GTDB. I believe that the authors even kind of discourage using the tax ids. I don't know if this would cause problems when merging across profilers, but you could add/use the last section of the clade name. Ex: becomes |
|
Hi @harper357, No need to apologize, more information is always welcome. Thank you for the explanation also, I was not aware how MetaPhlAn handles this. Unfortunately, even though such a change looks simple from the outside, it would change taxpasta's internal logic a lot. There's not only the validation part which assumes integers, but also the whole integration with an existing taxonomy. Basically, we only maintain the identifiers and if users desire, we add back names and lineages using the identifiers to get information from a taxonomy. @harper357 do you know if they publish their taxonomy in a format that can be read by taxopy? |
|
@Midnighter I am not completely sure on what the format for |
|
We use taxopy to load taxonomies in taxdump format. That means, we normally drop all information from individual profiles except taxon identifiers and their relative abundances. If a user wishes to output names, ranks, or lineages, we retrieve that from the taxonomy. There are two things that concern me with MetaPhlAn then. 1) You say that they use NCBI identifiers, but actually use a custom clustering. I don't know if that will practically make a big difference, but it's nonetheless misleading if true. 2) If they have their own clustering, it is straight forward to create the taxdump output, which will also assign unique identifiers that can be used. I realize that that will not happen soon, so we still need a solution right now. While I like your suggestion @harper357, it does have big consequences for how taxpasta is built. Need to think about that. It would also mean that the way we use taxonomies would not work for MetaPhlAn. |
|
I'll put this here in case it proves a helpful reference http://segatalab.cibio.unitn.it/data/Pasolli_et_al.html Also, I'll comment that mapping metaphlan outputs to ncbi taxonomy seems a reasonable use case nonetheless and makes sense to support even if imperfectly. |
|
having thought about it a bit since yesterday, maybe we need this to actually be two issues? one for supporting metaphlan on the ncbi taxonomy using the solution previously suggested by @Midnighter, w any warnings/ flags necessary. that sounded like itd be easy enough to do to serve as an interim solution and is probably worth supporting anyhow. and then a second issue for supporting metaphlan using a taxonomy built on SGBs. thatd be the more complete solution.. |
|
Thanks for all the work on there, and the follow-up on issues! 💪 I'm having a similar issue and wanted to be able to follow as well. |
|
I have not initiated any closer communication/collaboration. If you can establish a relationship that will be very beneficial for everyone. Feel free to point here and at taxprofiler for use-cases. |
Is there an existing issue for this?
Problem description
As in title, this report is forward from nf-core/taxprofiler#396.
The MetaPhlAn 4 output I'm using are in these gists, if any help:
2612_se_metaphlan4-db.metaphlan_profile.txt and 2613_se_metaphlan4-db.metaphlan_profile.txt
I think it's the duplicated tax id (as shown below) caused the error.
I also run
taxpasta standardiseon both MetaPhlAn 4 output files, taxpasta works but the result may have problem.From this result 'standard_2612.tsv' I got 4 entries with the same tax id and different count:
Code sample
Code run:
taxpasta merge \ -p metaphlan -o metaphlan_metaphlan4-db.tsv --add-name --add-rank --add-lineage --add-id-lineage --add-rank-lineage \ --taxonomy taxdump \ \ 2612_se_metaphlan4-db.metaphlan_profile.txt 2613_se_metaphlan4-db.metaphlan_profile.txtTraceback:
Traceback is too long, see this gist
At the end it says:
Environment
I'm running taxpastat under local docker container, which runs quay.io/biocontainers/taxpasta:0.6.1--pyhdfd78af_0
Anything else?
No response
The text was updated successfully, but these errors were encountered: