Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This depends on the learn.json from the main app #10

Open
ashnur opened this issue Jun 9, 2019 · 2 comments
Open

This depends on the learn.json from the main app #10

ashnur opened this issue Jun 9, 2019 · 2 comments

Comments

@ashnur
Copy link

ashnur commented Jun 9, 2019

Since https://github.com/tastejs/todomvc-common/blob/master/base.js#L248

If you want to inject some random content into every application you showcase, there are better ways than this.

@sindresorhus
Copy link
Member

there are better ways than this.

Ok, what are those better ways?

@ashnur
Copy link
Author

ashnur commented Jun 9, 2019

Depends, maybe you could move it above the comment, then it wouldn't be compulsory and people could delete it.
Or you could hardcode with the content so people see what they need to download and run.
Or just create a page where you embed the application and you control the context.
Or any number of other solutions where you don't provide a "template" with runtime errors out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants