Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use input transforms #242

Open
BioPhoton opened this issue Jul 13, 2023 · 0 comments
Open

use input transforms #242

BioPhoton opened this issue Jul 13, 2023 · 0 comments
Labels
feature New feature or request

Comments

@BioPhoton
Copy link
Member

Use input transforms wherever applicable.

example before:

  @Input({required: true})
  set lazy(component: RxInputType<Type<any>>) {
    this.connect('component', coerceObservable(component));
  }

example after:

  @Input({required: true, transform: <T>(value: RxInputType<T>) => coerceObservable(value)})
  set lazy(component: Observable<Type<any>>) {
    this.connect('component', component);
  }

or:

  @Input({required: true, transform: coerceObservable<Type<any>>})
  set lazy(component: Observable<Type<any>>) {
    this.connect('component', component);
  }
@BioPhoton BioPhoton added the feature New feature or request label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant