Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

feat: use enterprise_host to match github issue urls #89

Closed
AndersDJohnson opened this issue Oct 26, 2020 · 0 comments
Closed

feat: use enterprise_host to match github issue urls #89

AndersDJohnson opened this issue Oct 26, 2020 · 0 comments
Assignees
Labels
🔍 needs triage ✨ feat New feature or request

Comments

@AndersDJohnson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Today our GitHub regex makes some assumptions about the URL format for GitHub issues that is not consuming from enterprise_host configuration. This may result in some false positives, such as if I link to an issue on another GitHub instance (such as a reference to a public GitHub issue from an enterprise GitHub PR).

Describe the solution you'd like

A clear and concise description of what you want to happen.

We could update our GitHub URL finder to look for URLs starting with enterprise_host. That since it is required for non-public GitHub support, so we should be able to count on it. If one is not configured, we can only look for github.com and www.github.com URLs.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

What we have today mostly seems to work too, if the complexity here isn't worth it, or there are edge cases we've not considered.

Additional context

Add any other context or screenshots about the feature request here.

n/a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔍 needs triage ✨ feat New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants