Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 15 #41

Open
beatagent opened this issue Feb 8, 2023 · 5 comments
Open

Angular 15 #41

beatagent opened this issue Feb 8, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@beatagent
Copy link

It would be great if you could make an new version for Angular 15.

Thank you!
@beatagent beatagent added the enhancement New feature or request label Feb 8, 2023
@talohana
Copy link
Owner

talohana commented Feb 8, 2023

Thanks for raising this!

Could you please highlight what is missing or any errors you’ve encountered while using this with Angular 15?

@beatagent
Copy link
Author

Thank you for the quick answer!

When I make an npm update for my Angular 15 app I get the error:

npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^15.0.4" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^12.1.1" from [email protected]
npm ERR! node_modules/angular-dark-mode
npm ERR!   angular-dark-mode@"^3.0.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

With --legacy-peer-deps it works but this is not a permanent solution.

Additional it says

- angular-dark-mode [es2015/esm2015] (https://github.com/talohana/angular-dark-mode)
Encourage the library authors to publish an Ivy distribution.

Thank you!

@NusryNizam
Copy link

Yes, please add angular 15 support.

talohana added a commit that referenced this issue Mar 18, 2023
@talohana
chore(test): update to latest jest version
c52590d 
re #41
@talohana talohana mentioned this issue Mar 18, 2023
Merged
talohana added a commit that referenced this issue Mar 18, 2023
@talohana
chore(test): update to latest jest version
b1eb607 
re #41
talohana added a commit that referenced this issue Mar 20, 2023
@talohana
chore(test): update to latest jest version
c0c5290 
re #41
talohana added a commit that referenced this issue Mar 24, 2023
@talohana
feat: support angular v13 (#42)
8938fe8 
* feat: support Angular 13

* chore(test): update to latest jest version

* chore: add devcontainer config and update node version to v18

re #41
github-actions bot pushed a commit that referenced this issue Mar 24, 2023
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
d7c65b3 
# [3.1.0](v3.0.4...v3.1.0) (2023-03-24)

### Features

* support angular v13 ([#42](#42)) ([8938fe8](8938fe8)), closes [#41](#41)
@talohana talohana mentioned this issue Mar 24, 2023
Open
talohana added a commit that referenced this issue Mar 24, 2023
@talohana
feat: upgrade to angular v14
7f17666 
re #41
@Snawe
Copy link

Snawe commented May 20, 2023

And maybe, if already on it, update to support Angular 16 as well :D

@rbalet
Copy link
Collaborator

rbalet commented Feb 6, 2024

@Snawe Done on this pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@beatagent @Snawe @talohana @NusryNizam @rbalet