Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a --noninteractive option #419

Open
zackw opened this issue Feb 17, 2025 · 1 comment
Open

Please add a --noninteractive option #419

zackw opened this issue Feb 17, 2025 · 1 comment

Comments

@zackw
Copy link

zackw commented Feb 17, 2025

Currently there's only one place where cargo-llvm-cov might ask the user a question (installing llvm-tools-preview), and this can be suppressed with the CARGO_LLVM_COV_SETUP environment variable, but that variable is specific to that task. ask_to_run also looks at various variables to detect whether it is running in a CI environment, but it is inappropriate to set those variables when not running in CI as they can have other effects.

Please add a command line option (preferably) or an environment variable that means "do not ask any questions ever". The usual name for this option is --noninteractive.

@zackw
Copy link
Author

zackw commented Feb 17, 2025

Addendum: Unlike the current behavior of ask_to_run, the effect of --noninteractive should be as if the user said no to all prompts. This is what people expect of programs with a --noninteractive option. (I would argue that this is also what ask_to_run should do if it detects a CI environment, but that's less clear cut.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant