Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:CtrlPFunky always selects changes top split #54

Open
axelson opened this issue Oct 21, 2014 · 6 comments
Open

:CtrlPFunky always selects changes top split #54

axelson opened this issue Oct 21, 2014 · 6 comments
Labels

Comments

@axelson
Copy link

axelson commented Oct 21, 2014

Steps to reproduce:

  1. open a file in vim
  2. :sp to do a horizontal split
  3. ctrl-w j to move to bottom split
  4. :CtrlPFunky and select a function

Expected: CtrlPFunky to show the function in the bottom split
What actually happens: CtrlPFunky shows the function in the top split

Is this expected behavior? It throws me off when it happens. Also a similar issue happens for vertical splits.

@tacahiroy
Copy link
Owner

hmm - that is not expected behaviour. However, I don't reproduce the problem.
I've tested with like this small vimrc.

set nocompatible
filetype off
set rtp+=~/.vim/bundle/Vundle.vim
call vundle#rc()
call vundle#begin()
Plugin 'gmarik/Vundle.vim'
Plugin 'ctrlpvim/ctrlp.vim'
Plugin 'tacahiroy/ctrlp-funky'
call vundle#end()
filetype plugin indent on
let g:ctrlp_extensions = ['funky']

And step is like this:

  1. % vim -u vimrc.mini ~/.vimrc
  2. :sp ~/.zshrc
  3. <C-w>j
  4. :CtrlPFunky

@axelson
Copy link
Author

axelson commented Oct 24, 2014

I am still able to reproduce it with that vimrc. I think the difference is our step #2's are different. I am just using :sp so I can have a split of the same exact file, whereas you are splitting a different file.

@tacahiroy
Copy link
Owner

i see. So the problem is the active window is changed to top one, isn't it?
I've reproduced the problem and it's a bug.
will fix soon.

@axelson
Copy link
Author

axelson commented Oct 25, 2014

Yes, that is exactly it. Thanks for the awesome plug-in and I'm looking
forward to the fix!

tacahiroy added a commit that referenced this issue Oct 25, 2014
Note that this commit fixes the problem partly, kinda halfway fix.
Need more investigation
@tacahiroy
Copy link
Owner

I've just fixed the issue, it's kinda halfway fix though.
If you press Enter, it'll behave correctly.
The remaining problem is behaviour on cancel (= press ).

will continue to investigate this.

@axelson
Copy link
Author

axelson commented Oct 25, 2014

Wow, I didn't even realize that the cancel behavior was broken. The 'enter'
case works great for me now with your latest fix. Thanks!

On Sat Oct 25 2014 at 12:21:52 AM tacahiroy [email protected]
wrote:

I've just fixed the issue, it's kinda halfway fix though.
If you press Enter, it'll behave correctly.
The remaining problem is behaviour on cancel (= press ).

will continue to investigate this.


Reply to this email directly or view it on GitHub
#54 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants