Skip to content

Commit 8571932

Browse files
committed
hide unused veth pairs by default
1 parent 363dd82 commit 8571932

File tree

2 files changed

+35
-30
lines changed

2 files changed

+35
-30
lines changed

cmd/iftree/main.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,10 @@ import (
2525
var (
2626
debug = pflag.BoolP("debug", "d", false, "print debug message")
2727

28-
oGraph = pflag.BoolP("graph", "g", false, "output in png by defaul")
29-
oGraphType = pflag.StringP("gtype", "T", "png", `graph output type, "jpg", "png", "svg", "dot"(graphviz dot language(https://graphviz.org/doc/info/lang.html)`)
30-
oGraphName = pflag.StringP("output", "O", "output", "graph output name/path")
28+
oUnusedVeths = pflag.BoolP("all", "a", false, "show all veths, including unused.")
29+
oGraph = pflag.BoolP("graph", "g", false, "output in png by defaul")
30+
oGraphType = pflag.StringP("gtype", "T", "png", `graph output type, "jpg", "png", "svg", "dot"(graphviz dot language(https://graphviz.org/doc/info/lang.html)`)
31+
oGraphName = pflag.StringP("output", "O", "output", "graph output name/path")
3132

3233
oTable = pflag.BoolP("table", "t", false, "output in table")
3334

@@ -242,7 +243,7 @@ func main() {
242243
return
243244
}
244245

245-
if err := formatter.Print(os.Stdout, vm, netNsMap, vpairs); err != nil {
246+
if err := formatter.Print(os.Stdout, vm, netNsMap, vpairs, *oUnusedVeths); err != nil {
246247
log.Fatal(err)
247248
}
248249

pkg/formatter/text.go

Lines changed: 30 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ import (
1313
"github.com/t1anz0ng/iftree/pkg"
1414
)
1515

16-
func Print(w io.Writer, vm map[string][]pkg.Node, netNsMap map[int]string, vpairs []pkg.Node) error {
16+
func Print(w io.Writer, vm map[string][]pkg.Node,
17+
netNsMap map[int]string,
18+
vpairs []pkg.Node,
19+
all bool) error {
1720

1821
var content strings.Builder
1922
var vpair strings.Builder
@@ -61,32 +64,33 @@ func Print(w io.Writer, vm map[string][]pkg.Node, netNsMap map[int]string, vpair
6164
lw.SetStyle(list.StyleConnectedRounded)
6265
lw.Render()
6366

64-
lw.Reset()
65-
lw.SetOutputMirror(&vpair)
67+
var contents []string
68+
contents = append(contents, mainStype.Render(content.String()))
69+
if all {
70+
lw.Reset()
71+
lw.SetOutputMirror(&vpair)
6672

67-
fmt.Fprintln(&vpair, lipgloss.NewStyle().
68-
Background(lipgloss.Color("#F25D94")).
69-
MarginLeft(5).
70-
MarginRight(5).
71-
Padding(0, 1).
72-
Italic(true).
73-
Foreground(lipgloss.Color("#FFF7DB")).
74-
SetString("unused veth pairs"))
75-
lw.SetStyle(list.StyleConnectedRounded)
76-
for _, veth := range vpairs {
77-
lw.AppendItem(fmt.Sprintf("%s%s%s", veth.Veth,
78-
lipgloss.NewStyle().
79-
MarginRight(1).
80-
MarginLeft(1).
81-
Padding(0, 1).
82-
Foreground(special).SetString("<----->"),
83-
veth.Peer))
73+
fmt.Fprintln(&vpair, lipgloss.NewStyle().
74+
Background(lipgloss.Color("#F25D94")).
75+
MarginLeft(5).
76+
MarginRight(5).
77+
Padding(0, 1).
78+
Italic(true).
79+
Foreground(lipgloss.Color("#FFF7DB")).
80+
SetString("unused veth pairs"))
81+
lw.SetStyle(list.StyleConnectedRounded)
82+
for _, veth := range vpairs {
83+
lw.AppendItem(fmt.Sprintf("%s%s%s", veth.Veth,
84+
lipgloss.NewStyle().
85+
MarginRight(1).
86+
MarginLeft(1).
87+
Padding(0, 1).
88+
Foreground(special).SetString("<----->"),
89+
veth.Peer))
90+
}
91+
lw.Render()
92+
contents = append(contents, vethPairStyle.Render(vpair.String()))
8493
}
85-
lw.Render()
86-
fmt.Fprintln(w,
87-
lipgloss.JoinHorizontal(
88-
lipgloss.Top,
89-
mainStype.Render(content.String()),
90-
vethPairStyle.Render(vpair.String())))
94+
fmt.Fprintln(w, lipgloss.JoinVertical(lipgloss.Top, contents...))
9195
return nil
9296
}

0 commit comments

Comments
 (0)