Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iOS Safari #35

Open
ipragmatechadmin opened this issue May 27, 2019 · 5 comments
Open

Support iOS Safari #35

ipragmatechadmin opened this issue May 27, 2019 · 5 comments

Comments

@ipragmatechadmin
Copy link

@t-mullen Thanks for your hard work for this library but this library is not working on iOS Safari. We have a scenario where we need to use crop the video from the webcam and it didn't work for us. On further investigation, we found the issue with the patch applied for fixing Audio. After that, we found that the capture stream from canvas isn't working well on iOS Safari though it works fine on other browsers. Please take a look and fix this issue with this library. If you want then we can share the code which worked for us with the limitation that we are using directly canvas to show the video and not passing the stream to the video element.

@t-mullen t-mullen added the bug label Jun 26, 2019
@t-mullen
Copy link
Owner

This library is uses experimental APIs and I'm not surprised it doesn't work on iOS. I'm not even sure an iPhone could performantly do video composition, but I might be wrong.

Feel free to share any code you think would be helpful. You can email me anything you don't want to share publicly (but please keep support discussions to Github).

@t-mullen t-mullen changed the title Not Working on iOS Safari Support iOS Safari Jun 26, 2020
@archeelp
Copy link

@ipragmatechadmin can you please share the patch you made to make it work?
It would be a great help. Thank you.

@hthetiot
Copy link
Contributor

See #64 (comment)

@hthetiot
Copy link
Contributor

Fixing createConstantSource and moving canvas creation to start did the trick.

@hthetiot
Copy link
Contributor

hthetiot commented Jul 6, 2021

Fixed in 4.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants