Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed additional props for accessibility and others #966

Closed
Slooowpoke opened this issue May 31, 2020 · 2 comments · Fixed by #1122
Closed

Embed additional props for accessibility and others #966

Slooowpoke opened this issue May 31, 2020 · 2 comments · Fixed by #1122
Labels
enhancement New feature or request

Comments

@Slooowpoke
Copy link

When using the component, it would be nice to be able to pass down props onto the iframe. I couldn't find anything in the docs for it, but perhaps I've missed something?

Currently the component wraps an iframe in the div and props like aria-label or title are attached to the parent div instead of the iframe. Perhaps having something like iframeProps: {} is too verbose and not in keeping with ThemeUI but I can't think of anything that would work better.

An alternative could be for me to create a custom component with the nessecary props and I'm happy to do it if that's the recommended guidelines.

Additional context
It's mostly for some accessibility reasons but I'm sure there are other cases where it would be helpful.

@lachlanjc
Copy link
Member

To add clarity, I believe this issue is referring to the Embed component specifically

@lachlanjc
Copy link
Member

Related: #706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants