-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed additional props for accessibility and others #966
Labels
enhancement
New feature or request
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the component, it would be nice to be able to pass down props onto the iframe. I couldn't find anything in the docs for it, but perhaps I've missed something?
Currently the component wraps an iframe in the div and props like aria-label or title are attached to the parent div instead of the iframe. Perhaps having something like
iframeProps: {}
is too verbose and not in keeping with ThemeUI but I can't think of anything that would work better.An alternative could be for me to create a custom component with the nessecary props and I'm happy to do it if that's the recommended guidelines.
Additional context
It's mostly for some accessibility reasons but I'm sure there are other cases where it would be helpful.
The text was updated successfully, but these errors were encountered: