Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛱ Release v0.4.0 #1239

Closed
11 of 21 tasks
hasparus opened this issue Nov 5, 2020 · 16 comments
Closed
11 of 21 tasks

⛱ Release v0.4.0 #1239

hasparus opened this issue Nov 5, 2020 · 16 comments
Labels
internal Changes only affect the internal API

Comments

@hasparus
Copy link
Member

hasparus commented Nov 5, 2020

This is an umbrella issue for bugfixes, problems and tasks regarding next Theme UI releases.

I updated the changelog to include current additions to both previous and master (incomplete) branches.

Following list is obviously work in progress and a subject to change. Please feel free to discuss it and share your ideas in this issue.

To-Do

v0.3.2 (released)

  • Publish @theme-ui @0.3.2-alpha.10
    • gatsby-theme-ui-blog failed with 403
  • Test 0.3.2-alpha manually @hasparus
  • Make sure CHANGELOG.md is updated
  • Publish v0.3.2 from previous branch with bugfixes and minor improvements
  • Get all NPM permissions
  • Deploy updated docs from previous branch (This is not super urgent, there are mostly fixes to the docs there, no new content per se)

v0.4.0

  • Write a changelog
  • Publish 0.4.0-rc.7 with newest changes
  • Get permissions to deploy the docs? or deploy to another domain.
  • Deploy the docs
  • Give more people GitHub and NPM permissions.
  • Release final prerelease to test in our apps (0.4.0-rc.13)
  • Close "Convert to TypeScript" issue Convert to TypeScript #668

v0.5.0

Later

  • Type check property values against theme scales Theme UI v1 Roadmap #832 (css): Allow injecting UserTheme and typecheck colors against scale #1090
  • Set up longer CI tests — run tests in a few bigger open source respositories which use Theme UI. We have a huge API surface, and I'm worried our unit tests don't cover it fully. This would also be a nice check for unexpected breaking changes.
  • Solve React context discrepancy bugs
  • Migrate to Preconstruct and Changesets
  • Make continous canary releases in GitHub Actions
  • Continously deploy "next version" docs to another URL in GitHub Actions

cc @lachlanjc @atanasster @joe-bell @dcastil @nandorojo

@atanasster
Copy link
Collaborator

Great plan, whats the status of typescript converting the components package ?

@hasparus
Copy link
Member Author

hasparus commented Nov 5, 2020

Great plan, whats the status of typescript converting the components package ?

Not urgent? I don't expect myself working on it a lot, though if somebody needs a review or a pair programming session, I'd be happy to help.

@atanasster
Copy link
Collaborator

For me it was/is the biggest hurdle to learning theme-ui - the current syntax was very hard to read for me.

Whats the 0.4 timeLine, if there are still a few weeks i can take on this.

@hasparus
Copy link
Member Author

hasparus commented Nov 5, 2020

For me it was/is the biggest hurdle to learning theme-ui - the current syntax was very hard to read for me.

What do you mean by "syntax" here? The sx prop and pragmas?

@atanasster
Copy link
Collaborator

atanasster commented Nov 5, 2020 via email

@hasparus
Copy link
Member Author

hasparus commented Nov 5, 2020

Usually i look at the source to learn how to create my own components and in the case if theme-ui the js code for the components is not intuitive for me.

I'd get rid of styled-system dependency and rewrite to use Theme UI public API (sx prop).

@atanasster
Copy link
Collaborator

Yes agreed

@hasparus hasparus changed the title ⛱ Release v0.3.2 and v0.4.0 ⛱ Release v0.4.0 Nov 9, 2020
@hasparus
Copy link
Member Author

hasparus commented Nov 9, 2020

I released 0.3.2 and 0.4.0-rc.7 yesterday. 0.3.2 should be stable, 0.4.0-rc.7 contains minor breaking changes in types (useColorMode), but required updates shouldn't take longer than a minute.

Excerpt from changelog

v0.4.0-rc.7 2020-11-08

@theme-ui/core

  • Make ThemeProvider theme prop required

@theme-ui/editor

@theme-ui/preset-sketchy

  • Add @theme-ui/preset-sketchy

@theme-ui/prism

@theme-ui/sidenav

@theme-ui/style-guide

@theme-ui/color-modes

docs

  • Fix broken base-preset link on theming page

v0.3.2 2020-11-08

@theme-ui/css

@theme-ui/core

@theme-ui/components

docs

@dcastil
Copy link
Contributor

dcastil commented Nov 9, 2020

@hasparus What do you think about moving #1237 to a v0.5 release? v0.4 is in RC stage, so no new big features are expected and we could speed up the release by postponing this a little.

@sneridagh
Copy link

Emotion 11 is out! Is it possible to have it integrted soon?

@dcastil
Copy link
Contributor

dcastil commented Nov 12, 2020

@sneridagh Emotion 11 is part of the v1 roadmap, you can read more about it here #832

@sneridagh
Copy link

@dcastil ok, thanks! Seems a long list to reach there! Just wondering, how much are the expectations for it to happen?

@hasparus
Copy link
Member Author

hasparus commented Nov 12, 2020

@hasparus What do you think about moving #1237 to a v0.5 release? v0.4 is in RC stage, so no new big features are expected and we could speed up the release by postponing this a little.

Makes sense, @dcastil. So I suppose the only problem thing blocking 0.4 is deploying docs. I’ll get to it this weekend.

@jordie23
Copy link
Contributor

Anything stopping 0.4 now? Had a look at the commit logs, looks like you guys have done a huge amount of work recently that's really encouraging to see! Thanks for all the work you guys do, just want to say it's appreciated a lot. :D

@hasparus
Copy link
Member Author

@jordie23, You can use the last 0.4.0-rc version and treat it as stable. It won't get any breaking changes, maybe some important bugfixes.

  • Get permissions to deploy the docs? or deploy to another domain.
  • Deploy the docs
  • Give more people GitHub and NPM permissions.

We're not publishing it to NPM, because we can't deploy the docs to the main docs domain, nor change the fact that we link to it on repository page. Organizational problems are slower to solve than software problems.

@jordie23
Copy link
Contributor

@hasparus I understand now. Thanks for the info!

@lachlanjc lachlanjc added the internal Changes only affect the internal API label Dec 3, 2020
@hasparus hasparus closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

No branches or pull requests

6 participants