Fix mmu_invalidate_range for 8×2 set-associative #112
Merged
+17
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was attempting to access n_pages directly on mmu_cache_set_t structures, which don't have this member. The correct access path is cache_load[set].ways[way].n_pages for the 8-set × 2-way architecture.
The fix ensures all 16 load cache entries and 16 store cache entries are properly checked during range invalidation operations (e.g., SFENCE.VMA).
Summary by cubic
Fixed mmu_invalidate_range to correctly handle 8×2 set-associative load/store caches by iterating over sets and ways. Ensures SFENCE.VMA and range invalidations clear all relevant entries and prevent stale translations.
Written for commit ebe49d9. Summary will update automatically on new commits.