Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring UrlExecCommand for SSO auth #550

Open
amphied opened this issue Aug 21, 2023 · 0 comments
Open

Support configuring UrlExecCommand for SSO auth #550

amphied opened this issue Aug 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@amphied
Copy link

amphied commented Aug 21, 2023

Is your feature request related to a problem? Please describe.

It could be useful to allow overriding the UrlExecCommand for SSO auth. This could either be used to configure a different browser or be used for scripting.

Browser example: Launching Chrome in a specific profile

Scripting example: As mentioned in #524 I'd like to send the auth url to a script that relays it to a separate machine where my password safe and yubikey are located.

Describe the solution you'd like

Introduce a config option AuthUrlExecCommand similar to AuthUrlAction (overriding UrlAction). This could be either on global level or SSO-specific config or both:

SSOConfig:
    <Name of AWS SSO>:
        AuthUrlAction: [clip|exec|print|printurl|open|granted-containers|open-url-in-container]
        AuthUrlExecCommand:
            - <command>
            - <arg 1>
            - <arg N>
            - "%s"
AuthUrlExecCommand:
    - <command>
    - <arg 1>
    - <arg N>
    - "%s"

On a related note: I think it could be useful to have AuthUrlAction available globally, too.

Describe alternatives you've considered

Workarounds:

  1. Setting UrlExecCommand globally to a script that determines how to proceed based on the specific url.
  2. Setting the new config option AuthUrlAction to open and packaging a script into an .app so that it can be called with open -a foo.app (see open-golang) via the Browser config.

Implementation alternatives:

  1. Allowing overriding the global UrlExecCommand similar to DefaultRegion which can be set on every config level (SSO, Account, Role). Downside: massive config overhead.

Additional context

Related: #353, #524, #545

@amphied amphied added the enhancement New feature or request label Aug 21, 2023
@amphied amphied changed the title Support configuring urlExecCommand for SSO auth Support configuring UrlExecCommand for SSO auth Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant