-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all apostrophes transliterated properly into handles? #2905
Comments
I also have this problem. https://github.com/symphonycms/symphonycms/blob/master/symphony/lib/toolkit/class.general.php#L350 We should add ´ to the regex pattern |
@twiro For now, I would be glad to simply ignore ``` in 3.0.1. As for the other option, I would be open to suggestion. There are unit tests now, so implementing a remplacement should be waaaaaaaay easier... |
9447536 should take care of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected Symphony version(s) : 2.7.10
PHP version(s) : 7.2
OS(es) : –
I currently implemented a multilingual blog in a Symphony website and in the french version the client uses a lot of these apostrophes:
l´internet
.I don't really know if this is a valid choice for an apostroph in french (going with
l'internet
seems to be the more obvious choice), but what I know is that these apostrophes don't get transliterated properly, thus appear in the field handle and (when used in the in the title/url of the entry) cause my RSS-feed to not validate properly anymore.Example:
du-chien-berger-au-petinfluencer-rasta-conquit-l´internet-2019
Shouldn't this apostrophe get removed from the handle or is there any reason it is not part of the transliterations?
I did a quick search in the issues and noticed there have been long discussions about revisiting transliterations and moving to whitelisting instead of blacklisting, but they seem pretty old and I don't know what's the current state of this topic and if this counts as a bug that should be fixed in the 2.X-Branch or if this is something that will get addressed more globally in 3.X.
Any thoughts @nitriques ?
The text was updated successfully, but these errors were encountered: