New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby debugger highlighting false-positives #16357
Comments
bostonaholic
added a commit
to bostonaholic/spacemacs
that referenced
this issue
Apr 4, 2024
Fixes syl20bnr#16357 The change expands the matching regex to only highlight lines where the debugger is the first word on a line. The intended behavior is to highlight lines that are calling a ruby debugger. The purpose is to warn developers that might push code to production with a debugger enabled. The change expands the matching regex to only highlight lines where the debugger is the first word on a line. However, there are cases in which the regex is highlighting lines as a false-positive. I first noticed this in my `Gemfile` when it was highlighting the line below: ```ruby gem 'pry-byebug' ``` Other cases include: commented lines and defined function names that match a known debugger. See below for cases in which the line should and should not be highlighted. ```ruby class Test # This line below should not be highlighted def byebug byebug # this line should be highlighted # byebug This comment shouldn't be highlighted binding.irb # this line should be highlighted # binding.irb this line should not be highlighted binding.pry # this line should be highlighted # binding.pry this line should not be highlighted end end ```
smile13241324
pushed a commit
that referenced
this issue
May 11, 2024
Fixes #16357 The change expands the matching regex to only highlight lines where the debugger is the first word on a line. The intended behavior is to highlight lines that are calling a ruby debugger. The purpose is to warn developers that might push code to production with a debugger enabled. The change expands the matching regex to only highlight lines where the debugger is the first word on a line. However, there are cases in which the regex is highlighting lines as a false-positive. I first noticed this in my `Gemfile` when it was highlighting the line below: ```ruby gem 'pry-byebug' ``` Other cases include: commented lines and defined function names that match a known debugger. See below for cases in which the line should and should not be highlighted. ```ruby class Test # This line below should not be highlighted def byebug byebug # this line should be highlighted # byebug This comment shouldn't be highlighted binding.irb # this line should be highlighted # binding.irb this line should not be highlighted binding.pry # this line should be highlighted # binding.pry this line should not be highlighted end end ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Ruby debugger highlighting false-positives
Reproduction guide 馃
# byebug
Observed behaviour: 馃憖 馃挃
The line is highlighted as a warning.
Expected behaviour: 鉂わ笍 馃槃
The line is not highlighted.
System Info 馃捇
Backtrace 馃惥
The text was updated successfully, but these errors were encountered: