Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_fn is silent #672

Closed
bluurryy opened this issue May 7, 2024 · 0 comments · Fixed by #682
Closed

set_fn is silent #672

bluurryy opened this issue May 7, 2024 · 0 comments · Fixed by #682
Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working D-easy Difficulty: easy good first issue Good for newcomers

Comments

@bluurryy
Copy link

bluurryy commented May 7, 2024 •
edited
Loading

Expected behavior
set_fn should not be silent.

Environment

  • Sycamore: 0.9.0-beta.2 and master #86f0b05

Additional context
set_fn has the same body as set_fn_silent
@bluurryy bluurryy changed the title set_fn does update_silent instead of update set_fn is silent May 7, 2024
@lukechu10 lukechu10 added C-bug Category: bug, something isn't working good first issue Good for newcomers A-reactivity Area: reactivity and state handling D-easy Difficulty: easy labels May 7, 2024
@lukechu10 lukechu10 mentioned this issue Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working D-easy Difficulty: easy good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix set_fn to not be silent lukechu10/sycamore
2 participants
@lukechu10 @bluurryy