-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate HydrateNode
into DomNode
#542
Labels
A-ergonomics
Area: API ergonomics
C-enhancement
Category: new feature or improvement to existing feature
S-actionable
Actionable
Comments
lukechu10
added
C-enhancement
Category: new feature or improvement to existing feature
A-ergonomics
Area: API ergonomics
S-actionable
Actionable
S-unactionable
Unactionable
labels
Dec 11, 2022
This would be extremely beneficial for Perseus, as it would allow more idiomatic distinctions between rendering and hydration (sometimes in Perseus, even when we're asked to hydrate, we actually need to fully render, e.g. if we have more info about an error than the server did). More broadly, I think this will help a lot of future systems doing any kind of SSR error handling! |
Draft
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ergonomics
Area: API ergonomics
C-enhancement
Category: new feature or improvement to existing feature
S-actionable
Actionable
The current split is a bit confusing and not very useful. It would be better to merge
HydrateNode
back intoDomNode
. The hydration-specific functionality can still be feature-gated to not pay the performance penalty when it is not needed.The text was updated successfully, but these errors were encountered: