Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate HydrateNode into DomNode #542

Open
lukechu10 opened this issue Dec 11, 2022 · 1 comment · May be fixed by #669
Open

Consolidate HydrateNode into DomNode #542

lukechu10 opened this issue Dec 11, 2022 · 1 comment · May be fixed by #669
Labels
A-ergonomics Area: API ergonomics C-enhancement Category: new feature or improvement to existing feature S-actionable Actionable

Comments

@lukechu10
Copy link
Collaborator

The current split is a bit confusing and not very useful. It would be better to merge HydrateNode back into DomNode. The hydration-specific functionality can still be feature-gated to not pay the performance penalty when it is not needed.

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-ergonomics Area: API ergonomics S-actionable Actionable S-unactionable Unactionable labels Dec 11, 2022
@arctic-hen7
Copy link
Contributor

This would be extremely beneficial for Perseus, as it would allow more idiomatic distinctions between rendering and hydration (sometimes in Perseus, even when we're asked to hydrate, we actually need to fully render, e.g. if we have more info about an error than the server did). More broadly, I think this will help a lot of future systems doing any kind of SSR error handling!

@lukechu10 lukechu10 removed the S-unactionable Unactionable label Dec 11, 2022
@lukechu10 lukechu10 linked a pull request Apr 3, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ergonomics Area: API ergonomics C-enhancement Category: new feature or improvement to existing feature S-actionable Actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants