'
@@ -331,7 +332,7 @@ private static function get_account_info() {
) );
$output .= static::wrap_row_content( \esc_html__( 'API endpoint:', 'the-seo-framework-extension-manager' ), $_ep_html, false );
- if ( is_int( $requests_remaining ) ) {
+ if ( \is_int( $requests_remaining ) ) {
$_notice = '';
$_classes = [ 'tsfem-dashicon' ];
diff --git a/inc/classes/listedit.class.php b/inc/classes/listedit.class.php
index 028f9f74..ab1cd671 100644
--- a/inc/classes/listedit.class.php
+++ b/inc/classes/listedit.class.php
@@ -138,7 +138,8 @@ private function construct() {
//= Saving.
\add_action( 'save_post', [ static::class, '_verify_nonce_post' ], 1, 2 );
- // \add_action( 'edit_term', [ static::class, '_verify_nonce_term' ], 1, 3 ); // No extension supports this.
+ // phpcs:ignore -- No extension supports this.
+ // \add_action( 'edit_term', [ static::class, '_verify_nonce_term' ], 1, 3 );
//= Output.
\add_action( 'the_seo_framework_after_quick_edit', [ $this, '_load_quick_sections' ], 10, 2 );
@@ -240,7 +241,7 @@ private function register_default_scripts() {
'name' => 'tsfem-listedit',
'base' => TSF_EXTENSION_MANAGER_DIR_URL . 'lib/js/',
'ver' => TSF_EXTENSION_MANAGER_VERSION,
- 'l10n' => [
+ 'l10n' => [
'name' => 'tsfem_listeditL10n',
'data' => [],
],
diff --git a/inc/functions/api.php b/inc/functions/api.php
index e5f30ebe..7021589c 100644
--- a/inc/functions/api.php
+++ b/inc/functions/api.php
@@ -145,7 +145,7 @@ function _load_wp_compat( $version = '' ) {
if ( isset( $loaded[ $version ] ) )
return $loaded[ $version ];
- if ( empty( $version ) || 3 !== strlen( $version ) ) {
+ if ( empty( $version ) || 3 !== \strlen( $version ) ) {
\the_seo_framework()->_doing_it_wrong( __FUNCTION__, 'You must tell the two-point required WordPress version.' );
return $loaded[ $version ] = false;
}
diff --git a/inc/traits/core/error.trait.php b/inc/traits/core/error.trait.php
index a1401359..719331c2 100644
--- a/inc/traits/core/error.trait.php
+++ b/inc/traits/core/error.trait.php
@@ -75,21 +75,22 @@ final protected function init_errors() {
*/
final public function _do_error_notices() {
- if ( $options = \get_option( $this->error_notice_option, false ) ) {
+ $options = \get_option( $this->error_notice_option, false );
- $notices = $this->get_error_notices( $options );
+ if ( ! $options ) return;
- if ( empty( $notices ) ) {
- $this->unset_error_notice_option();
- return;
- }
-
- // Already escaped.
- foreach ( $notices as $notice )
- \tsf_extension_manager()->do_dismissible_notice( $notice['message'], $notice['type'], true, false );
+ $notices = $this->get_error_notices( $options );
+ if ( empty( $notices ) ) {
$this->unset_error_notice_option();
+ return;
}
+
+ // Already escaped.
+ foreach ( $notices as $notice )
+ \tsf_extension_manager()->do_dismissible_notice( $notice['message'], $notice['type'], true, false );
+
+ $this->unset_error_notice_option();
}
/**
@@ -121,7 +122,7 @@ final protected function set_error_notice( $notice = [], $clear_old = false ) {
//# This prevents adding timestamps preemptively in the future.
//? We could form a timestamp collection per notice, separately.
//# But, that would cause performance issues.
- if ( in_array( $notice, $notices, true ) ) {
+ if ( \in_array( $notice, $notices, true ) ) {
//= We already have the notice stored in cache.
return;
} else {
@@ -155,7 +156,7 @@ final protected function unset_error_notice_option() {
*/
final protected function get_error_notice( $option ) {
- if ( is_array( $option ) ) {
+ if ( \is_array( $option ) ) {
$key = key( $option );
} elseif ( is_scalar( $option ) ) {
$key = $option;
@@ -165,7 +166,7 @@ final protected function get_error_notice( $option ) {
return '';
$notice = $this->get_error_notice_by_key( $key, true );
- $additional_info = is_array( $option ) && ! empty( $option[ $key ] ) ? $option[ $key ] : '';
+ $additional_info = \is_array( $option ) && ! empty( $option[ $key ] ) ? $option[ $key ] : '';
$args = [
'type' => $notice['type'],
@@ -333,7 +334,7 @@ protected function get_error_notice_by_key( $key, $get_type = true ) {
\esc_html__( 'Invalid API license key. Login to the %s page to find a valid API License Key.', 'the-seo-framework-extension-manager' ),
$this->get_my_account_link()
);
- $type = 'error';
+ $type = 'error';
break;
case 304:
@@ -386,7 +387,7 @@ protected function get_error_notice_by_key( $key, $get_type = true ) {
\esc_html__( 'Exceeded maximum number of activations. Login to the %s page to manage your sites.', 'the-seo-framework-extension-manager' ),
$this->get_my_account_link()
);
- $type = 'error';
+ $type = 'error';
break;
case 306:
@@ -437,7 +438,7 @@ protected function get_error_notice_by_key( $key, $get_type = true ) {
\esc_html__( "Your subscription instance couldn't be verified. Login to the %s page and verify if this site is still connected.", 'the-seo-framework-extension-manager' ),
$this->get_my_account_link()
);
- $type = 'warning';
+ $type = 'warning';
break;
case 904:
diff --git a/inc/traits/core/overload.trait.php b/inc/traits/core/overload.trait.php
index d74644b3..dd9e1f9f 100644
--- a/inc/traits/core/overload.trait.php
+++ b/inc/traits/core/overload.trait.php
@@ -24,6 +24,10 @@
* along with this program. If not, see
.
*/
+// phpcs:disable, Generic.Files.OneObjectStructurePerFile.MultipleFound -- Collection, not auto-loaded nor class-mapped.
+// phpcs:disable, Generic.CodeAnalysis.UselessOverridingMethod.Found -- Enforced, not useless.
+// phpcs:disable, Squiz.Commenting.FunctionComment.Missing -- The trait doc explains it.
+
/**
* Legend/Definitions:
*
@@ -106,8 +110,6 @@
* -
: Should not exist.
*/
-// phpcs:disable, Squiz.Commenting.FunctionComment.Missing -- Implied.
-
/**
* Holds private overloading functions to prevent injection or abstraction.
*
@@ -356,7 +358,7 @@ final private function __construct() {}
*/
final public static function set_instance() {
- if ( is_null( static::$instance ) ) {
+ if ( \is_null( static::$instance ) ) {
static::$instance = new static();
}
}
@@ -372,7 +374,7 @@ final public static function set_instance() {
*/
final public static function get_instance() {
- if ( is_null( static::$instance ) ) {
+ if ( \is_null( static::$instance ) ) {
static::set_instance();
}
@@ -418,7 +420,7 @@ private function __construct() {}
*/
private static function set_instance() {
- if ( is_null( static::$instance ) ) {
+ if ( \is_null( static::$instance ) ) {
static::$instance = new static();
}
}
@@ -434,7 +436,7 @@ private static function set_instance() {
*/
private static function get_instance() {
- if ( is_null( static::$instance ) ) {
+ if ( \is_null( static::$instance ) ) {
static::set_instance();
}
@@ -503,7 +505,7 @@ trait Ignore_Properties_Core_Public_Final {
* @param string $name The inexisting property name.
* @param mixed $value The propertie value that ought to be set.
*/
- final public function __set( $name = '', $value = null ) {
+ final public function __set( $name = '', $value = null ) { // phpcs:ignore, VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
\the_seo_framework()->_doing_it_wrong( __METHOD__, \esc_html( __CLASS__ . '::$' . $name . ' does not exist.' ) );
}
diff --git a/inc/traits/core/ui.trait.php b/inc/traits/core/ui.trait.php
index b8b0d353..d13da665 100644
--- a/inc/traits/core/ui.trait.php
+++ b/inc/traits/core/ui.trait.php
@@ -137,7 +137,7 @@ final public function panes_wrap() {
printf(
'',
// phpcs:ignore, WordPress.Security.EscapeOutput.OutputNotEscaped
- in_array( $this->wrap_type, [ 'column', 'row' ], true ) ? $this->wrap_type : 'column'
+ \in_array( $this->wrap_type, [ 'column', 'row' ], true ) ? $this->wrap_type : 'column'
);
\do_action( 'tsfem_content' );
echo '';
@@ -306,9 +306,10 @@ final protected function register_form_scripts( $scripts ) {
'name' => 'tsfemFormL10n',
'data' => [
'nonce' => \TSF_Extension_Manager\can_do_extension_settings() ? \wp_create_nonce( 'tsfem-form-nonce' ) : '',
- 'callee' => get_class( $this ), //! Don't use __CLASS__, we require the core instance.
+ 'callee' => \get_class( $this ), //! Don't use __CLASS__, we require the core instance.
'i18n' => [
- // TODO categorize
+ // TODO categorize in multidimensionals
+ // phpcs:disable, WordPress.Arrays.MultipleStatementAlignment -- Alignment is fine.
// Validation.
'requiredSelectAny' => \esc_html__( 'Please select any of the fields to proceed.', 'the-seo-framework-extension-manager' ),
@@ -333,13 +334,16 @@ final protected function register_form_scripts( $scripts ) {
'selectAddressTitle' => \esc_html__( 'Select address', 'the-seo-framework-extension-manager' ),
'selectAddressText' => \esc_html__( 'Select an address below.', 'the-seo-framework-extension-manager' ),
'reverseGeoWarning' => \esc_html__( 'Validation will be done only using Latitude and Longitude.', 'the-seo-framework-extension-manager' ),
+ // phpcs:enable, WordPress.Arrays.MultipleStatementAlignment
],
],
],
+ // phpcs:disable
// Inherits from 'tsfem'
// 'tmpl' => [
// 'file' => \tsf_extension_manager()->get_template_location( 'fbtopnotice' ),
// ],
+ // phpcs:enable
],
] );
}
@@ -381,6 +385,7 @@ final protected function register_media_scripts( $scripts ) {
'imgRemoveTitle' => \esc_attr__( 'Remove selected image', 'the-seo-framework-extension-manager' ),
'imgFrameTitle' => \esc_attr_x( 'Select Image', 'Frame title', 'the-seo-framework-extension-manager' ),
'imgFrameButton' => \esc_attr__( 'Use this image', 'the-seo-framework-extension-manager' ),
+ // phpcs:ignore -- redundant, maybe later.
// 'mediaEnqueued' => \wp_style_is( 'media', 'enqueued' ),
],
],
diff --git a/inc/traits/extension/forms.trait.php b/inc/traits/extension/forms.trait.php
index 99ece1d8..eee1aa14 100644
--- a/inc/traits/extension/forms.trait.php
+++ b/inc/traits/extension/forms.trait.php
@@ -237,7 +237,7 @@ public function _get_action_button( $url = '', array $items = [] ) {
return '';
}
- if ( empty( $items['input'] ) || ! is_array( $items['input'] ) ) {
+ if ( empty( $items['input'] ) || ! \is_array( $items['input'] ) ) {
\the_seo_framework()->_doing_it_wrong( __METHOD__, 'Form input items must be in an array. Supply at least a submit button.' );
return '';
}
diff --git a/inc/traits/extension/options.trait.php b/inc/traits/extension/options.trait.php
index a6268b94..d962083a 100644
--- a/inc/traits/extension/options.trait.php
+++ b/inc/traits/extension/options.trait.php
@@ -24,6 +24,8 @@
* along with this program. If not, see .
*/
+// phpcs:disable, Generic.Files.OneObjectStructurePerFile.MultipleFound -- Classes intertwine for cache abstraction.
+
/**
* Class TSF_Extension_Manager\Extensions_Options_Cache.
*
@@ -68,7 +70,7 @@ private static function init_options_cache() {
*/
public static function _get_options_cache() {
- if ( is_null( static::$options ) )
+ if ( \is_null( static::$options ) )
static::init_options_cache();
return static::$options;
@@ -92,7 +94,7 @@ public static function _get_options_cache() {
*/
public static function _set_options_cache( $index = '', $new_options = null, $delete = false ) {
- if ( is_null( static::$options ) )
+ if ( \is_null( static::$options ) )
static::init_options_cache();
if ( isset( $new_options ) && $index ) {
@@ -149,7 +151,7 @@ private static function init_options_cache() {
*/
public static function _get_options_cache() {
- if ( is_null( static::$options ) )
+ if ( \is_null( static::$options ) )
static::init_options_cache();
return static::$options;
@@ -173,7 +175,7 @@ public static function _get_options_cache() {
*/
public static function _set_options_cache( $index = '', $new_options = null, $delete = false ) {
- if ( is_null( static::$options ) )
+ if ( \is_null( static::$options ) )
static::init_options_cache();
if ( isset( $new_options ) && $index ) {
diff --git a/inc/traits/extension/post-meta.trait.php b/inc/traits/extension/post-meta.trait.php
index 85654e71..4c50e592 100644
--- a/inc/traits/extension/post-meta.trait.php
+++ b/inc/traits/extension/post-meta.trait.php
@@ -24,6 +24,8 @@
* along with this program. If not, see .
*/
+// phpcs:disable, Generic.Files.OneObjectStructurePerFile.MultipleFound -- Class and trait intertwine for cache abstraction.
+
/**
* Class TSF_Extension_Manager\Extensions_Post_Meta_Cache.
*
@@ -268,8 +270,8 @@ final protected function update_post_meta( $key, $value ) {
$c_meta = Extensions_Post_Meta_Cache::_get_meta_cache( $this->pm_id );
$c_meta[ $this->pm_index ] = $meta;
- // phpcs:ignore -- Security check OK, this is a serialization of an array, sub-unserialization can't happen.
// Addslashes here, so WordPress doesn't unslash it, whereafter unserialization fails.
+ // phpcs:ignore -- Security check OK, this is a serialization of an array, sub-unserialization can't happen.
$success = \update_post_meta( $this->pm_id, TSF_EXTENSION_MANAGER_EXTENSION_POST_META, addslashes( serialize( $c_meta ) ) );
if ( $success ) {
@@ -308,8 +310,8 @@ final protected function delete_post_meta( $key ) {
$c_meta = Extensions_Post_Meta_Cache::_get_meta_cache( $this->pm_id );
$c_meta[ $this->pm_index ] = $meta;
- // phpcs:ignore -- Security check OK, this is a serialization of an array, sub-unserialization can't happen.
// Addslashes here, so WordPress doesn't unslash it, whereafter unserialization fails.
+ // phpcs:ignore -- Security check OK, this is a serialization of an array, sub-unserialization can't happen.
$success = \update_post_meta( $this->pm_id, TSF_EXTENSION_MANAGER_EXTENSION_POST_META, addslashes( serialize( $c_meta ) ) );
if ( $success ) {
diff --git a/inc/traits/factory/memory.trait.php b/inc/traits/factory/memory.trait.php
index 78ac3f18..076838b7 100644
--- a/inc/traits/factory/memory.trait.php
+++ b/inc/traits/factory/memory.trait.php
@@ -24,6 +24,8 @@
* along with this program. If not, see .
*/
+// phpcs:disable, Generic.Files.OneObjectStructurePerFile.MultipleFound -- Class and trait intertwine for cache abstraction.
+
/**
* Holds memory cache for the Memory trait.
* Ironically.
@@ -61,7 +63,7 @@ final public static function get_memory_limit_in_bytes() {
return $limit;
$_limit = trim( ini_get( 'memory_limit' ) );
- $quantifier = strtolower( $_limit[ strlen( $_limit ) - 1 ] );
+ $quantifier = strtolower( $_limit[ \strlen( $_limit ) - 1 ] );
$val = filter_var( $_limit, FILTER_SANITIZE_NUMBER_INT );
switch ( $quantifier ) {
diff --git a/inc/traits/factory/time.trait.php b/inc/traits/factory/time.trait.php
index 5551bf55..0210c5f8 100644
--- a/inc/traits/factory/time.trait.php
+++ b/inc/traits/factory/time.trait.php
@@ -124,7 +124,7 @@ protected function get_time_ago_i18n( $since ) {
*/
protected function get_rectified_date( $format, $timestamp = null ) {
- is_null( $timestamp )
+ \is_null( $timestamp )
and $timestamp = time();
$tsf = \the_seo_framework();
@@ -150,7 +150,7 @@ protected function get_rectified_date( $format, $timestamp = null ) {
*/
protected function get_rectified_date_i18n( $format, $timestamp = null ) {
- is_null( $timestamp )
+ \is_null( $timestamp )
and $timestamp = time();
$tsf = \the_seo_framework();
@@ -267,7 +267,7 @@ protected function _upscale_time( $x, $x_scale, $scales, $precise ) {
$_threshold = $scale_table[ $x_scale ][0];
if ( $x_remaining >= $_threshold // > vs >= is 24 hours vs 1 day.
- && ( ! $precise || ( count( $times ) < $scales - 1 ) ) // -1 as we're adding another to reach this.
+ && ( ! $precise || ( \count( $times ) < $scales - 1 ) ) // -1 as we're adding another to reach this.
) {
if ( $x_remaining % $_threshold ) {
// Calculate current and next time scale.
@@ -296,7 +296,7 @@ protected function _upscale_time( $x, $x_scale, $scales, $precise ) {
$times = array_reverse( $times );
//= Don't return more items than the threshold.
- $count = min( count( $times ), $scales );
+ $count = min( \count( $times ), $scales );
for ( $i = 0; $i < $count; $i++ ) {
if ( 0 === $i ) {
diff --git a/inc/traits/manager/extensions-layout.trait.php b/inc/traits/manager/extensions-layout.trait.php
index d0c12c3d..484dea3f 100644
--- a/inc/traits/manager/extensions-layout.trait.php
+++ b/inc/traits/manager/extensions-layout.trait.php
@@ -24,6 +24,8 @@
* along with this program. If not, see .
*/
+// phpcs:disable, Generic.Files.OneObjectStructurePerFile.MultipleFound -- Traits intertwine.
+
/**
* Holds i18n data functions for class TSF_Extension_Manager\Extensions.
*
@@ -129,7 +131,7 @@ private static function get_extensions_list() {
if ( ! isset( $extension['slug'], $extension['type'], $extension['area'] ) )
continue;
- if ( in_array( $extension['slug'], (array) TSF_EXTENSION_MANAGER_HIDDEN_EXTENSIONS, true ) )
+ if ( \in_array( $extension['slug'], (array) TSF_EXTENSION_MANAGER_HIDDEN_EXTENSIONS, true ) )
continue;
if ( false === static::get_extension_header( $extension['slug'] ) )
@@ -244,7 +246,7 @@ private static function make_extension_subheader( $extension ) {
$party_class = 'first' === $extension['party'] ? 'tsfem-extension-first-party-icon' : 'tsfem-extension-third-party-icon';
$party_title = 'first' === $extension['party'] ? static::get_i18n( 'first-party' ) : static::get_i18n( 'third-party' );
- $party = sprintf( '', $party_class, \esc_attr( $party_title ) );
+ $party = sprintf( '', $party_class, \esc_attr( $party_title ) );
$author = '' . \esc_html( static::get_extension_header( $extension['slug'] )['Author'] ) . '';
return '';
@@ -328,7 +330,7 @@ private static function get_extension_button_form( $slug = '', $type = '', $disa
return '';
endswitch;
- $disabled = $disabled || array_key_exists( $slug, (array) TSF_EXTENSION_MANAGER_FORCED_EXTENSIONS );
+ $disabled = $disabled || \array_key_exists( $slug, (array) TSF_EXTENSION_MANAGER_FORCED_EXTENSIONS );
if ( $disabled ) {
$button = sprintf( '%s', $s_class, \esc_html( $text ) );
@@ -352,13 +354,13 @@ private static function get_extension_button_form( $slug = '', $type = '', $disa
$cache['input_name'],
$s_slug
);
- $submit = sprintf(
+ $submit = sprintf(
'',
$s_slug,
$s_class,
\esc_attr( $text )
);
- $nojs = sprintf(
+ $nojs = sprintf(
'',
$cache['admin_url'],
$s_slug,
@@ -425,10 +427,12 @@ private static function get_extension_description_footer( $extension, $wrap = tr
$data = static::get_extension_header( $extension['slug'] );
$items = [];
- // Make extension author element. (move link to what's already shown?)
+ // phpcs:disable
+ // MAYBE: Make extension author element. (move link to what's already shown?)
// $author = $data['Author'];
// $author_url = $data['AuthorURI'];
// $author = sprintf( '%s', \esc_url( $author_url, [ 'https', 'http' ] ), \esc_attr( static::get_i18n( 'visit-author' ) ), \esc_html( $author ) );
+ // phpcs:enable
// Make extension version element.
$items['version'] = sprintf( '%s %s',
@@ -494,7 +498,7 @@ private static function get_extension_desc_compat_item( $extension ) {
$incompatibility = static::determine_extension_incompatibility( $extension );
if ( $incompatibility & ( TSFEM_EXTENSION_TSF_INCOMPATIBLE | TSFEM_EXTENSION_WP_INCOMPATIBLE ) ) {
- $compat_class = 'tsfem-error';
+ $compat_class = 'tsfem-error';
$compat_notice = sprintf(
/* translators: 1: Version number, 2: Version number */
\__( 'WordPress %1$s and The SEO Framework %2$s are required.', 'the-seo-framework-extension-manager' ),
@@ -517,8 +521,8 @@ private static function get_extension_desc_compat_item( $extension ) {
break;
endswitch;
- $compat_class = 'tsfem-unknown';
- $compat_name = static::get_i18n( 'compatible' );
+ $compat_class = 'tsfem-unknown';
+ $compat_name = static::get_i18n( 'compatible' );
$compat_notice .= '
' . \__( 'The extension will always be tested for errors before activation.', 'the-seo-framework-extension-manager' );
} else {
$compat_class = 'tsfem-success';
diff --git a/inc/traits/manager/extensions.trait.php b/inc/traits/manager/extensions.trait.php
index 248a636c..33f12d02 100644
--- a/inc/traits/manager/extensions.trait.php
+++ b/inc/traits/manager/extensions.trait.php
@@ -24,6 +24,8 @@
* along with this program. If not, see .
*/
+// phpcs:disable, Generic.Files.OneObjectStructurePerFile.MultipleFound -- Traits intertwine.
+
/**
* Holds extension data check functions for class TSF_Extension_Manager\Extensions.
*
@@ -332,6 +334,7 @@ private static function get_extension_relative_path( $slug ) {
if ( empty( $extension ) )
return '';
+ // phpcs:ignore -- No network support like this, yet.
// $network = static::is_extension_network( $extension );
$premium = static::is_extension_premium( $extension );
$essentials = static::is_extension_essentials( $extension );
@@ -339,6 +342,7 @@ private static function get_extension_relative_path( $slug ) {
$path[ $slug ] = '';
$path[ $slug ] .= 'extensions/';
+ // phpcs:ignore -- No network support like this, yet.
// $path[ $slug ] .= $network ? 'network/' : '';
$path[ $slug ] .= $premium ? 'premium/' : ( $essentials ? 'essentials/' : 'free/' );
$path[ $slug ] .= $slug . '/';
@@ -358,10 +362,11 @@ private static function get_extension_relative_path( $slug ) {
*/
private static function get_extension_header_file_location( $slug ) {
- if ( $path = static::get_extension_trunk_path( $slug ) )
- return $path . $slug . '.php';
+ $path = static::get_extension_trunk_path( $slug );
+
+ if ( ! $path ) return '';
- return '';
+ return $path . $slug . '.php';
}
/**
@@ -513,7 +518,7 @@ private static function get_active_extensions( $placeholder = [] ) {
|| ! $is_premium_user && static::is_extension_premium( $_extension )
|| ( ! $is_connected_user && static::is_extension_essentials( $_extension ) )
|| ( ! static::is_extension_compatible( $_extension ) )
- ) {
+ ) {
unset( $extensions[ $_extension ] );
}
}
@@ -1049,6 +1054,7 @@ public static function _shutdown_handle_test_extension_fatal_error() {
$error['message'] = static::clean_error_message( $error['message'], $error );
$error_notice = $error_type . ' ' . \esc_html__( 'Extension is not compatible with your server configuration.', 'the-seo-framework-extension-manager' );
+
$advanced_error_notice = \esc_html( $error['message'] ) . ' in file ' . \esc_html( $error['file'] ) . ' on line ' . \esc_html( $error['line'] ) . '.';
if ( \wp_doing_ajax() ) {
@@ -1087,6 +1093,8 @@ public static function _shutdown_handle_test_extension_fatal_error() {
*/
private static function clean_error_message( $message = '', $error = [] ) {
+ // phpcs:disable, WordPress.CodeAnalysis.AssignmentInCondition
+
// Remove stack trace.
if ( false !== ( $stack_pos = stripos( $message, 'Stack trace:' ) ) )
$message = substr( $message, 0, $stack_pos );
@@ -1106,6 +1114,8 @@ private static function clean_error_message( $message = '', $error = [] ) {
}
}
+ // phpcs:enable, WordPress.CodeAnalysis.AssignmentInCondition
+
return $message;
}
diff --git a/inc/traits/manager/options.trait.php b/inc/traits/manager/options.trait.php
index 6b9c284f..ec2590ba 100644
--- a/inc/traits/manager/options.trait.php
+++ b/inc/traits/manager/options.trait.php
@@ -216,7 +216,7 @@ final protected function update_option_multi( array $options = [], $type = 'inst
// This won't fire the filter 'wp_parse_str'. As $options requires to be an array.
$options = \wp_parse_args( $options, $_options );
- $run = true;
+ $run = true;
$this->initialize_option_update_instance( $type );
@@ -393,9 +393,9 @@ final protected function kill_options() {
$success = [
$this->delete_options_instance(),
- \delete_option( TSF_EXTENSION_MANAGER_SITE_OPTIONS )
+ \delete_option( TSF_EXTENSION_MANAGER_SITE_OPTIONS ),
];
- return $this->killed_options = ! in_array( false, $success, true );
+ return $this->killed_options = ! \in_array( false, $success, true );
}
}
diff --git a/phpcs.xml b/phpcs.xml
index 05887b67..b6835226 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -11,7 +11,7 @@
-
+
diff --git a/the-seo-framework-extension-manager.php b/the-seo-framework-extension-manager.php
index ff1093ee..a21828b7 100644
--- a/the-seo-framework-extension-manager.php
+++ b/the-seo-framework-extension-manager.php
@@ -3,7 +3,7 @@
* Plugin Name: The SEO Framework - Extension Manager
* Plugin URI: https://theseoframework.com/extension-manager/
* Description: Add more powerful SEO features to The SEO Framework. Right from your WordPress dashboard.
- * Version: 2.4.1-dev-2
+ * Version: 2.4.1-dev-3
* Author: The SEO Framework Team
* Author URI: https://theseoframework.com/
* License: GPLv3
diff --git a/views/layout/extension/top.php b/views/layout/extension/top.php
index 880ff370..0cd5502d 100644
--- a/views/layout/extension/top.php
+++ b/views/layout/extension/top.php
@@ -14,7 +14,6 @@
tsf_extension_manager()->get_image_file_location( 'tsflogo.svg', true ),
- // '2x' => tsf_extension_manager()->get_image_file_location( 'tsflogo-58x58px.png', true ),
'1x' => tsf_extension_manager()->get_image_file_location( 'tsflogo-29x29px.png', true ),
];
$size = '1em';
diff --git a/views/layout/general/top.php b/views/layout/general/top.php
index e4d6ccbc..1a743e52 100644
--- a/views/layout/general/top.php
+++ b/views/layout/general/top.php
@@ -60,7 +60,6 @@
$this->get_image_file_location( 'tsflogo.svg', true ),
- // '2x' => $this->get_image_file_location( 'tsflogo-58x58px.png', true ),
'1x' => $this->get_image_file_location( 'tsflogo-29x29px.png', true ),
];
$size = '1em';
diff --git a/views/layout/pages/activation.php b/views/layout/pages/activation.php
index a58c9865..c0f361fd 100644
--- a/views/layout/pages/activation.php
+++ b/views/layout/pages/activation.php
@@ -24,10 +24,12 @@
get_view( 'forms/get', [ 'name' => $this->request_name['activate-external'], 'action' => $this->get_activation_url( 'get/' ), 'redirect' => 'activate', 'text' => \__( 'Get your API key', 'the-seo-framework-extension-manager' ), 'classes' => [ 'tsfem-button', 'tsfem-button-primary' ] ] );
// $this->get_view( 'forms/get', [ 'name' => $this->request_name['activate-external'], 'action' => $this->get_activation_url( 'get/' ), 'redirect' => 'connect', 'text' => \__( 'Connect', 'the-seo-framework-extension-manager' ), 'classes' => [ 'tsfem-button' ] ] );
// $this->get_remote_activation_listener();
+ // phpcs:enable
// phpcs:disable, WordPress.Security.EscapeOutput.OutputNotEscaped -- get_link() escapes
echo $this->get_link( [