Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yazi v0.3 TODO List #836

Closed
sxyazi opened this issue Mar 22, 2024 · 4 comments
Closed

Yazi v0.3 TODO List #836

sxyazi opened this issue Mar 22, 2024 · 4 comments
Labels
feature New feature request

Comments

@sxyazi
Copy link
Owner

sxyazi commented Mar 22, 2024

Yazi v0.3 is not expected to arrive soon. Because of this, I am noting here the tasks that need to be completed in the future, so that I don't forget them.

Use ffmpeg instead of ffmpegthumbnailer as the video preview dependency

ffmpegthumbnailer is in an inactive maintenance state. Its latest version 2.2.2 was released in 2019 and is unavailable on some platforms.

Use Ctrl-c instead of Ctrl-q as the universal close key for all components

Ctrl-c is more in line with conventions, and it's closer to Ctrl, which makes it more convenient to press. See #763 (comment) and #779 (comment) for more details.

Add ImageMagick as an optional dependency

Note: this will be an optional dependency, not required.

Some users ask me how to preview SVG/heic/JPEG-XL in Yazi, but the image library used by Yazi (https://github.com/image-rs/image) does not support them.

One of Yazi's main selling points is the built-in image preview, so I think I should strive to provide users with an out-of-the-box experience on that.

@AntoniosBarotsis
Copy link

For ffmpegthumbnailer, I was wondering what difficulties using ffmpeg instead could entail. I'm guessing that this is the relevant code.

Wouldn't it be possible to use something like this? I am blissfully unaware of the complexities of anything ffmpeg related 😅

@sxyazi
Copy link
Owner Author

sxyazi commented May 17, 2024

what difficulties using ffmpeg instead could entail

Some Windows users have reported to me that they cannot successfully build ffmpegthumbnailer on Windows. As a result, video previews are unavailable to Yazi's Windows users, and it is indeed in a state of lack of maintenance.

Bud yesterday I tried ffmpeg and found that there's no easy way to generate thumbnails by percentage, only by precise time. Since ffmpeg is the only alternative to ffmpegthumbnailer that I know of (if there are others, please let me know), it might not happen until we find any good alternative solutions.

@sxyazi
Copy link
Owner Author

sxyazi commented May 17, 2024

All done (50ae6eb, e10fb2a, 65afe60) except ffmpegthumbnailer, closing this todo list

@sxyazi sxyazi closed this as completed May 17, 2024
@AntoniosBarotsis
Copy link

@sxyazi if the percentage is the hold up then couldn't we get the video's duration with 1 ffmpeg call and then figure out exactly when you want to get the thumbnail? Would the 2 calls needed be problematic for performance? In that case maybe we could look into the sdk instead of spawning an external process.

Not sure if I misunderstood what you meant by percentage. I'm guessing you meant something like "give me the frame at the 20% point of the video duration" but I could be completely wrong.

I'm on windows myself so I'm trying to figure out if this is within my capabilities to implement 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants