Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

Upgrade to new engine fork and upstream support #11

Open
a1batross opened this issue Oct 30, 2019 · 1 comment
Open

Upgrade to new engine fork and upstream support #11

a1batross opened this issue Oct 30, 2019 · 1 comment

Comments

@a1batross
Copy link
Contributor

a1batross commented Oct 30, 2019

Hi! Congratulations on your port. :)

We're, i.e. FWGS, dropping old engine support soon once and forever. However, we have new fork based on final Xash3D release and even some unique features, like multiple renderers support. :)

Only few things are required to be changed:

  • Cleaner code, you almost don't have problem with this :))
  • You should agree to maintain your own port. It's not hard, just test global changes and report if other dev has broken something and participate in your port related issues discussion, i.e. bugreports. I recommend you to setup CI for perpetual building and deploying engine updates, so everyone will know which commit has broken 3DS build.
  • Move from Makefiles to Waf build system.

If you have questions, ping me here or in our Discord server.

@Myaats
Copy link
Contributor

Myaats commented Oct 30, 2019

Thanks for pointing this out, I was already aware of the new fork but it was not really mature last I checked (which is ages ago by now). I'll happily look into it when I have time, but one of the biggest blockers on helping out with the new upstream fork is the current toolchain (devkitPro) which might be tricky to integrate with Waf and the requirement of everything being statically compiled due to toolchain limitations.

I suggest adding methods for statically compiling game dlls into a single executable upstream before attempting to get a new switch port up and running.

I think using symbol renaming to avoid conflicts instead of the current method which is a script scanning all files and generating a header with #define's that gets included everywhere to override the symbols. But this is just a suggestion.

Also another thing is reducing the amount of file operations, I remember the old upstream wrote a ton of files every time a save & autosave was created resulting in freezing everything for seconds. This is not critical but would increase the quality of gameplay.

Also I am already in the FWGS Discord (Mats#6045) if you want to talk with me about more details

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants