Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate cache issues #474

Open
swissspidy opened this issue May 15, 2024 · 5 comments
Open

Investigate cache issues #474

swissspidy opened this issue May 15, 2024 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed p3 unconfirmed

Comments

@swissspidy
Copy link
Owner

If vips.worker.js is strongly cached in the browser there can be issues. Investigate how to best clear that cache.

@swissspidy swissspidy added bug Something isn't working help wanted Extra attention is needed labels May 15, 2024
kleisauke added a commit to kleisauke/media-experiments that referenced this issue Jun 1, 2024
- Worker script is inlined into the main output file.
- Simplify resize logic using the `pageHeight` property.

Resolves: swissspidy#474.
kleisauke added a commit to kleisauke/media-experiments that referenced this issue Jun 1, 2024
- Worker script is inlined into the main output file.
- Simplify resize logic using the `pageHeight` property.

Resolves: swissspidy#474.
kleisauke added a commit to kleisauke/media-experiments that referenced this issue Jun 1, 2024
- Worker script is inlined into the main output file.
- Simplify resize logic using the `pageHeight` property.

Resolves: swissspidy#474.
@swissspidy swissspidy added the p2 label Jun 6, 2024
@swissspidy
Copy link
Owner Author

Maybe can append __webpack_hash__ somewhere?

@kleisauke
Copy link
Contributor

In PR #603, I did this for *.wasm files:

// Use [contenthash:8] to help with cache busting.
filename: '[name].[contenthash:8].wasm',

A similar approach can be done here:

filename: '[name].js',

However, this will append a hash to all JavaScript files, including media-experiments.js, which may not be very useful.

@swissspidy
Copy link
Owner Author

I wanted to pass a function for chunkFileName in the past, but this is blocked by Shopify/quilt#2807

@kleisauke
Copy link
Contributor

Issue Shopify/quilt#2807 has been resolved via PR Shopify/quilt#2816 and #701, but unfortunately, Quilt is no longer maintained, and all its packages have been deprecated. 🤷‍♂️

@swissspidy
Copy link
Owner Author

swissspidy commented Oct 10, 2024

That's not the good-news-bad-news combo I was expecting. 😢

Guess I'll need to look for alternatives... 😕

Edit:

At least the underlying rpc package is not deprecated, see https://github.com/Shopify/remote-dom/tree/remote-ui/packages/rpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed p3 unconfirmed
Projects
None yet
Development

No branches or pull requests

2 participants