Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Context Menu (asynchronous) demo doesn't work with right-click #735

Open
ericprud opened this issue Sep 21, 2020 · 0 comments
Open

Comments

@ericprud
Copy link
Contributor

ericprud commented Sep 21, 2020

In documentation/demo/async-create, the button says "right click me" but doesn't behave as expected in:

  • firefox - the contextmenu gets rendered after the browser's default context menu has rendered.
  • chromium - only the browser's default context menu is rendered.

The async-create demo builds the items immediately upon click event. I think the common use case is that the items take a while to construct and that $this.contextmenu() is fired when they're ready.

Also, the captured event is mouseup, which means it doesn't translate to common cases where folks need mouseup and contextmenu to be different. Switching the event to contextmenu would address this but you theen need to disable the contextmenu handler during execution because the call to $this.contextmenu() triggers it again.

#8 addresses these points with a new demo, which could be moved to async-create.md to remedy the above issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant