Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx-select caret scales inconsistently #583

Open
mcwenger opened this issue Apr 8, 2021 · 1 comment
Open

ngx-select caret scales inconsistently #583

mcwenger opened this issue Apr 8, 2021 · 1 comment
Assignees
Labels

Comments

@mcwenger
Copy link
Contributor

mcwenger commented Apr 8, 2021

.ngx-select-caret is sized with em units, so it appears smaller than the expected default when a parent container has a declared em/rem font size.

@joeveiga
Copy link

@mcwenger Is the expected behavior here that both the .ngx-select-caret and the .ngx-select-clear maintain their fixed size, or should they both grow/shrink relative to the component font-size property? At the moment .ngx-select-caret is using relative units as you pointed out, while the .ngx-select-clear button has a fixed px size, which causes a visual inconsistency. E.g.:

ngx-select {
  font-size: 2em;
}

image
image

IMHO it'd look better if both buttons grew with the rest of the text around them, but it's up to you. Please advice, and I'll take care of this one. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants