Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods which never return (like run) should be marked as -> Never #151

Open
helje5 opened this issue Jul 31, 2020 · 2 comments
Open

Methods which never return (like run) should be marked as -> Never #151

helje5 opened this issue Jul 31, 2020 · 2 comments
Labels
enhancement New feature or request ⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Milestone
1.0.0-alpha.1

Comments

@helje5
Copy link

helje5 commented Jul 31, 2020

As per PR #150, which needs to be fixed in more places.

Note that this is API semver major, so for 2.x.
@helje5 helje5 mentioned this issue Jul 31, 2020
Closed
@helje5
Copy link
Author

helje5 commented Jul 31, 2020

Of course you should be very sure whether you want the Never behaviour, but if you do - as documented -, it should return Never.

Why might you not want Never? I don't know, maybe because some Lambda's would want to switch the bootstrap for some crazy reason?

@tomerd tomerd added the enhancement New feature or request label Jul 31, 2020
@tomerd
Copy link
Contributor

tomerd commented Jul 31, 2020

lets do this with other breaking API changes for 1.0

@fabianfett fabianfett added the ⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0 label Aug 3, 2020
@tomerd tomerd added this to the 1.0.0 milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Projects
None yet
Milestone
1.0.0-alpha.1
Development

No branches or pull requests
3 participants
@tomerd @fabianfett @helje5