Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for HTTPClientError.remoteConnectionCloseds to be automatically retried #715

Open
MahdiBM opened this issue Oct 29, 2023 · 1 comment

Comments

@MahdiBM
Copy link
Contributor

MahdiBM commented Oct 29, 2023

In all apps i've used AHC in, we experience relatively-infrequent but consistent HTTPClientError.remoteConnectionCloseds.
Frequency-wise, my non-scientific approximation would be something like 1/50_000 requests (depends on a lot of factors of course).

These errors seem to happen consistently due to usual network inconsistencies, and they almost never indicate any actual problems on user's side.

I expect AHC to be able to automatically retry these errors so users have a more consistent experience when making requests.
Perhaps there could be a setting like the existing retryConnectionEstablishment.

Worths mentioning that I do also see other kinds of errors here and there, but only inconsistently and much less frequently, so i don't think the other errors are worth retrying, unlike remoteConnectionClosed.

@MahdiBM MahdiBM changed the title Option for HTTPClientError.remoteConnectionCloseds to be automatically retired Option for HTTPClientError.remoteConnectionCloseds to be automatically retried Oct 29, 2023
@Lukasa
Copy link
Collaborator

Lukasa commented Nov 6, 2023

Yes, this seems like a good feature request. @dnadoba can you have a think about when we could tackle proper retry support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants