Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should change your default animation behavior. Its to much fancy馃檹 #2589

Open
ghost opened this issue Jan 17, 2023 · 5 comments
Open
Labels
help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jan 17, 2023

Thank you.

@DrPeeps
Copy link

DrPeeps commented Mar 3, 2023

I don't know about "fancy", but I have to agree that this is not the best choice of animation for the default. To me it's more of a comical, cartoonish effect; I can't help but hear the sound "BOOOIIIOIIIOIIING!" in my head every time a modal pops up. :)

I expect anyone developing a serious website will have to change this setting, as I have.

@kenara
Copy link

kenara commented Mar 4, 2023

@DrPeeps can you share the change you made?
Not sure the criteria is "serious website" but it might be useful to be able to adjust the animation.

@limonte limonte added the help wanted Extra attention is needed label Mar 4, 2023
@limonte
Copy link
Member

limonte commented Mar 4, 2023

I kinda agree with you guys, any suggestions are welcome 馃檶

@DrPeeps
Copy link

DrPeeps commented Mar 5, 2023

Not sure the criteria is "serious website"

Oh, definitely not! I realize some websites are more fun in theme than others and maybe the current default is more suitable for most projects. I don't know. My own feeling is that something more "bland" would be a safer default. People can always set it to the elastic style if they want.

I changed my default modals to the following for now, and I think it looks nice:

showClass: {popup: "animate__animated animate__fadeIn animate__faster"}

@stathis1998
Copy link

I kinda agree with you guys, any suggestions are welcome 馃檶

Maybe try a plain 0 to 100 animation like HeadlessUI does on Modals with Tailwind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants