Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nginx base image in DockerFile #10151

Open
sahilpatil2997 opened this issue Sep 30, 2024 · 4 comments
Open

Upgrade nginx base image in DockerFile #10151

sahilpatil2997 opened this issue Sep 30, 2024 · 4 comments

Comments

@sahilpatil2997
Copy link

sahilpatil2997 commented Sep 30, 2024

The nginx base image version 1.27.0-alpine has some critical vulnerabilities, so please upgrade the base image of nginx in the DockerFile and upgrade the docker image version of the swagger-ui

The vulnerabilities using the v5.17.14 is mentioned in the screenshot
image

These vulnerabilities are mainly in the nginx 1.27.0-alpine docker image like this
image

The nginx 1.27.0-alpine doesn't have much vulnerabilities
image

So please upgrade the nginx docker image to 1.27.0-alpine

@navalBhagat
Copy link

Hi, I am a first time contributor and was looking for a good first issue.
I'm a bit confused though. You mention that the docker image should be upgraded to 1.27.0-alpine, but it is already using that. Do you mean 1.27.1/2-alpine? And is this something the dependabot already does, or does it only do it for major version changes?

@sahilpatil2997
Copy link
Author

sahilpatil2997 commented Oct 4, 2024

Hey @navalBhagat,

You mention that the docker image should be upgraded to 1.27.0-alpine, but it is already using that

I said to upgrade the nginx base image in the DockerFile to 1.27.1-alpine, 1.27.0-alpine has some critical vulnerabilities that the newer version does not have, I suggested this version because there were few major and not critical vulnerabilities, you are free to upgrade to whichever version you like keeping in mind that the version should have any critical vulnerabilities

And is this something the dependabot already does, or does it only do it for major version changes

I think dependabot is scanning the image but no one is looking at the report, most of the Docker Build has failed, as per the list, please do look at the Docker Build Pipeline/Security check reports as well

@navalBhagat
Copy link

Thanks for clarifying! I'll pick up this issue :)

@sahilpatil2997
Copy link
Author

The @swagger-bot merged this PR #10163, but still the vulnerability persists, please merge #10161, so that the vulnerabilities are resolved and also the build job, will pass, please check into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants