Skip to content

Commit 4f4c333

Browse files
committed
logging code cleanup
1 parent feb2c01 commit 4f4c333

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

wfb_ng/__init__.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ def color_str(arg, c, bold=False):
8989

9090
class ConsoleObserver(object):
9191
def emit(self, eventDict):
92-
print('[%s] %s' % (eventDict['system'], eventDict['log_text']))
93-
sys.stdout.flush()
92+
txt = '\n '.join(str(eventDict['log_text']).rstrip().split('\n'))
93+
print('[%s] %s' % (eventDict['system'], txt), flush=True)
9494

9595

9696
def __find_caller(depth):
@@ -142,14 +142,24 @@ class LogLevel(object):
142142
LogLevel.ALERT : 'alert',
143143
LogLevel.FATAL : 'fatal_error'}
144144

145+
min_level = LogLevel.DEBUG
146+
147+
148+
def set_log_level(level):
149+
global min_level
150+
min_level = level
151+
145152

146153
def _log_msg(*args, **kwargs):
147154
level = kwargs.get('level', None)
148155

149-
if level not in set(LogLevel.__dict__.values()):
156+
if level not in log_level_map:
150157
level = LogLevel.ERROR if kwargs.get('isError') else LogLevel.INFO
151158
kwargs['level'] = level
152159

160+
if level < min_level:
161+
return
162+
153163
error = (level >= LogLevel.ERROR)
154164
kwargs['isError'] = 1 if error else 0
155165
module, func = __find_caller(2)

wfb_ng/server.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
from twisted.python import log, failure
3232
from twisted.internet import reactor, defer
3333

34-
from . import _log_msg, ConsoleObserver, ErrorSafeLogFile, call_and_check_rc, ExecError, version_msg
34+
from . import _log_msg, ConsoleObserver, ErrorSafeLogFile, call_and_check_rc, ExecError, version_msg, LogLevel, set_log_level
3535
from .common import abort_on_crash, exit_status, df_sleep, search_attr
3636
from .protocols import AntStatsAndSelector, RFTempMeter, SSHClientProtocol, MsgPackAPIFactory, JSONAPIFactory, notify_ready
3737
from .services import parse_services, init_udp_direct_tx, init_udp_direct_rx, init_mavlink, init_tunnel, init_udp_proxy, hash_link_domain, bandwidth_map
@@ -304,6 +304,7 @@ def main():
304304
print(gen_bind_yaml(args.profiles))
305305
return
306306

307+
set_log_level(LogLevel.DEBUG if settings.common.debug else LogLevel.INFO)
307308
log.msg = _log_msg
308309

309310
if settings.common.log_file:

0 commit comments

Comments
 (0)