Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI tests #789

Open
XhmikosR opened this issue Mar 29, 2023 · 2 comments
Open

Add CLI tests #789

XhmikosR opened this issue Mar 29, 2023 · 2 comments
Labels
enhancement help-wanted tests

Comments

@XhmikosR
Copy link
Member

Currently CLI isn't covered by tests at all. Any PRs to improve the situation are more than welcome even minor :)
This was referenced Mar 29, 2023
Open
Open
@XhmikosR XhmikosR mentioned this issue Apr 11, 2023
Open
@Kreeg Kreeg mentioned this issue Apr 12, 2023
Open
@XhmikosR XhmikosR pinned this issue May 27, 2023
@chimok
Copy link

chimok commented Oct 18, 2023

Hello @XhmikosR,

i suggest to split packages, svg-sprite is only the library and then create a separate project svg-sprite-cli. If you like the idea I can help with the cli.

@XhmikosR
Copy link
Member Author

XhmikosR commented Apr 3, 2024

@chimok We could do it, but this is assuming that the CLI has tests. Otherwise, given the limited resources we have, would be sort of moot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help-wanted tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XhmikosR @chimok