New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volar hybrid mode compatibility with typescript-svelte-plugin #2307
Comments
dummdidumm
pushed a commit
that referenced
this issue
Apr 25, 2024
#2307 Improve the svelte project check for InferredProject. Start from the current directory and go down 2 levels in the directory tree to search for package.json. Then we use the directories with package.json to search for svelte modules. If your ts-plugin is no longer enabled, you can create a jsconfig.json where your package.json is. This alone should resolve most problems since the plugin won't be applied at all. Disable the plugin in the config level until we receive the _typescript.configurePlugin request. This should decrease the chance of the project update because of the config toggle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Thread for tracking Volar hybrid mode compatibility issues. Documenting some issues currently found and continuing the conversation of microsoft/TypeScript#57630.
"svelte.enable-ts-plugin": false
config doesn't do anything until a ts/js file is opened.For 2, we might need to disable the ts plugin when the config is
{ global: true, ... }
and enable it when the config request we sent arrives.Probably Volar problems:
getScriptVersion
to be a compound version id but TypeScript expect update should only happen throughProject.updateGraph
. Might need to check if this only happens if the Svelte extension is enabled.@johnsoncodehk, Also, I can't reliably reproduce the problem reported in microsoft/TypeScript#57630. Can you provide a more detailed step?
Reproduction
microsoft/TypeScript#57630
Expected behaviour
compatible
System Info
Which package is the issue about?
No response
Additional Information, eg. Screenshots
No response
The text was updated successfully, but these errors were encountered: