Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for top level r2s scripts (and refactor as needed) #31

Open
2 of 4 tasks
erelson opened this issue Jan 16, 2013 · 1 comment
Open
2 of 4 tasks

Create tests for top level r2s scripts (and refactor as needed) #31

erelson opened this issue Jan 16, 2013 · 1 comment
Assignees

Comments

@erelson
Copy link
Contributor

erelson commented Jan 16, 2013

The r2s_step1.py and r2s_step2.py scripts in particular need tests.

Some of the other scripts at the top level (r2s_setup.py and r2s_step2setup.py) also need tests.

I was looking at r2s_step2setup.py with this in mind, and ended up refactoring it into a handful of methods so that it's more testable. The same would probably be appropriate for the other scripts.

  • r2s_setup.py
  • r2s_step1.py
  • r2s_step2.py
  • r2s_step2setup.py
@ghost ghost assigned elliottbiondo Jan 22, 2013
@erelson
Copy link
Contributor Author

erelson commented Jan 22, 2013

@elliottbiondo I've assigned this to you, tentatively; I've done step 2 and step 2 setup, which you can use as a guide for step 1. I also refactored both of those scripts to make them actually testable. Probably a good idea for r2s_step1.py as well.

erelson added a commit that referenced this issue Mar 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants