Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback from Marc #85

Open
bebraw opened this issue Aug 6, 2018 · 3 comments
Open

Feedback from Marc #85

bebraw opened this issue Aug 6, 2018 · 3 comments
Labels
enhancement

Comments

@bebraw
Copy link
Member

bebraw commented Aug 6, 2018

  • I think you should add one line to talk about the runner ups and deprecated alternatives to npm in the intro about packages. Component and Bower comes to mind. Also another sentence about stuff like jspm, duojs, yarn and pnpm wouldn't hurt.
  • In the UMD chapter you could link to https://github.com/LeeCheneler/umd-generator
  • You should link to keepachangelog in the changelog chapter.
sapegin added a commit that referenced this issue Aug 6, 2018
@sapegin
Add a link to keepachangelog.com
0806a15 
#85
@sapegin
Copy link
Member

sapegin commented Aug 6, 2018 •
edited
Loading

  1. I'm not really sure what would be the value of covering deprecated package managers.

  2. I'm likely missing something, but I'm not really sure what it does ;-/ What we really need to cover is microbundle — Cover microbundle #87.

  3. Good point, done — 0806a15!

@bebraw
Copy link
Member Author

bebraw commented Aug 6, 2018

  1. Yarn and pnpm are worth mentioning so people see their benefits. Esp. pnpm feels underrated as not many people know about it.
  2. Microbundle is enough, yeah. UMD should be something handled by a bundler.
  3. Perfect.

@sapegin
Copy link
Member

sapegin commented Aug 6, 2018

  1. Yarn — definitely, they have some nice features for maintainers, but digging Bower grave — I'm not that sure ;-/

sapegin added a commit that referenced this issue Sep 8, 2018
@sapegin
Rewrite Standalone Builds chapter to use Microbundle instead of Rollup
3470221 
Closes #87
Related to #85
@sapegin sapegin mentioned this issue Sep 8, 2018
Merged
bebraw pushed a commit that referenced this issue Sep 9, 2018
@sapegin @bebraw
Rewrite Standalone Builds chapter to use Microbundle instead of Rollup (
c433aed 
#89)

* Rewrite Standalone Builds chapter to use Microbundle instead of Rollup

Closes #87
Related to #85

* Add --save-dev flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sapegin @bebraw