-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: Find a way to reduce PactSwiftMockServer repo size #117
Comments
As a first pass Edit: |
❕ Problem Statement
PactMockServer exposes the wrapper around
libpact_ffi
in a XCFramework package. But the libpact_ffi binaries built from Rust code (https://github.com/pact-foundation/pact-reference/tree/master/rust/pact_ffi) contain binaries for simulators and physical devices. The problem is that all these binaries are static and include the rust runtime code for each of the platforms we're supporting (x86_64, aarm for both simulator and physical devices - so there's 4 copies of .a for each version). These binaries are huge! They hover at just over 100MB for each platform. That also means a lot of bandwidth is chewed up and long time to fetchPactSwift
package onto dev's machines. It also uses up unnecessary disk space on developers' machines!Although it's nice to not worry about running Pact tests on a specific target, it doesn't really make sense to run them on a physical device. It doesn't make much sense and it's rather hard finding where the Pact contract have been written to on a physical device and then trying to extract it.
We can consider just failing terribly when a developer tries to run Pact tests on a physical device, or "gracefully" fail the test with a meaningful message? Not fussed.
surpher/PactSwift
allows developers to run tests on a physical device at the moment, but skips writing the Pact contract onto an iDevice's disk.💡 Or maybe look into having
PactSwiftMockServer
package only contain the source files and can we leverage SPM Plugins to fetchlibpact_ffi
binaries separately from repo? This could also let us drop dealing withrust
altogether as we could potentially spm-plugin-execute fetching a binary from pact-foundation/pact-reference that's already been built before webuild xcframework
to vend fromPactSwiftMockServer
.The thing is that each update to
libpact_ffi
"baked" into the repo just explodes the size that each project pulls in.For example, pact-foundation/pact-reference is releasing these binaries and hosting them on GitHub, but we'll need to improve their script generating the static libs to use the right triples we would need (eg: aarch64-apple-ios-sim, x86_64-apple-ios and aarch64-apple-darwin, x86_64-apple-darwin).
Another option to reduce the
libpact_ffi
size for macOS targets would be to share a dynamic lib? The released FFI libs pact-reference/rust offers are around 7MB in size.But moving to a dynamic lib for macOS would mean developers would also need to install
rust
on their machines? This could prove as a big barrier to adoption of PactSwift.Reach out to me (@surpher) and we can talk about all of the approaches I've thought up. There's been quite a few, and a few approaches I've already tried I am really not proud of!
💬 Task Description
lib.a
s into repo - perhaps a SPM plugin that would fetch the prebuiltlibpact_ffi.a
from pact-foundation and insert it?👩🔧 Technical Design Notes
🤝 Relationships
The text was updated successfully, but these errors were encountered: