Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Consider hand crafting the storybook demos instead of using govuk examples (Relegating these to tests only) #47

Open
andymantell opened this issue Feb 18, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@andymantell
Copy link
Collaborator

As per the comment at #45 (comment) it is not immediately clear upon viewing the storybook that you can pass components to children props and not just html. The html in the demos is technically in JSX form, implying that components could be used also but it's very easy to miss that and just see html.

Might be worth considering hand crafting a smaller set of clearer demos, and relegating the govuk examples to the test suite only.

@andymantell andymantell added the documentation Improvements or additions to documentation label Feb 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant