Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Looking for an updated example of react-hook-form #105

Open
brightpixels opened this issue Feb 16, 2021 · 3 comments
Open

Looking for an updated example of react-hook-form #105

brightpixels opened this issue Feb 16, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@brightpixels
Copy link

Hello,
The current example of react-hook-form is broken. Could you please update it or give guidance. https://github.com/surevine/govuk-react-jsx-examples/blob/master/src/forms/ReactHookForm.js
Thanks

@andymantell
Copy link
Collaborator

I will update it when I can but I'm not able to give a prompt response to this unfortunately. I don't believe anything is broken in this library that makes it incompatible with react-hook-form, but react-hook-form changed enough that my example code no longer worked. It wasn't completely broken - it was just the validation wasn't working I think.

Is there anything in the react-hook-form docs you can use to work out what the changes are and whether you are able to fix this yourself?

@brightpixels
Copy link
Author

Thanks. Closing for now and will reopen or raise an issue for more specific issues. If all good, I will raise PR on your example.

@andymantell
Copy link
Collaborator

Thanks @brightpixels.

I'm actually going to reopen this ticket though as a reminder as I do need at some point to fix that example. I hastily commented it out because it was broken and didn't have time to do anything better with it...

@andymantell andymantell reopened this Feb 16, 2021
@andymantell andymantell added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants