Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appimage icon #2594

Closed
dingyifei opened this issue Mar 29, 2022 · 17 comments
Closed

Appimage icon #2594

dingyifei opened this issue Mar 29, 2022 · 17 comments
Labels
help wanted Someone can do the work and submit a pull request? problem ubuntu

Comments

@dingyifei
Copy link

Is your feature request related to a problem? Please describe.
The appimage doesn't contain a default icon. The icon only shows up when the program is running.

Describe the solution you'd like
Default icon for appimage

Describe how it would work
Basically copy the icon to another location inside the appimage. Some prusa slicer users came up with a solution but probably gave up on it for some reason...
prusa3d#7801

Describe alternatives you've considered
no icon is fine

Additional context
Add any other context or paint drawing about the feature request here.

@supermerill
Copy link
Owner

There is already a SuperSlicer.png at the appimage root.
Why it doesn't work on your linux?

@supermerill supermerill added working as intended unless you prove me wrong. could not reproduce awaiting response Further information is requested and removed enhancement working as intended unless you prove me wrong. labels Mar 30, 2022
@dingyifei
Copy link
Author

It seems to be a common issue, where the icon isn't in usr/share/icons of the appimage.

AppImageCommunity/libappimage#165

I'm running fedora 35 with the default Gnome installation, where the LycheeSlicer AppImage has an icon but SS has no icon. It is strange when I extract and re-pack the LyCheeSlicer, the new AppImage doesn't have an icon...

@supermerill supermerill added help wanted Someone can do the work and submit a pull request? problem ubuntu and removed could not reproduce awaiting response Further information is requested labels Mar 30, 2022
@bassamanator
Copy link

I'm on Manjaro, using today's release. No icon is showing for me.

| SuperSlicer Version 2.3.57 SuperSlicer-ubuntu_18.04-gtk2-2.3.57.12.AppImage
| Operating System: Manjaro Linux
KDE Plasma Version: 5.24.3
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Kernel Version: 5.15.28-1-MANJARO (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 2700X Eight-Core Processor
Memory: 31.4 GiB of RAM
Graphics Processor: AMD Radeon RX 580 Series

@supermerill
Copy link
Owner

what i have to do for it to appear?

@dingyifei
Copy link
Author

dingyifei commented Apr 3, 2022

what i have to do for it to appear?

based on this issue, AppImageCommunity/libappimage#165, add a folder in appimage with the same icon.

Something like usr/share/icons/hicolor/192x192/apps/superslicericon

@supermerill
Copy link
Owner

supermerill commented Apr 3, 2022

so, with / the root directory inside the appimage archive, I have to copy my (current) /SuperSlicer.png to /usr/share/icons/hicolor/192x192/apps/SuperSlicer.png ?

note that the desktop entry of the appimage is:

[Desktop Entry]
Name=SuperSlicer
Exec=AppRun %F
Icon=SuperSlicer
Type=Application
Categories=Utility;
MimeType=model/stl;application/vnd.ms-3mfdocument;application/prs.wavefront-obj;application/x-amf;

supermerill added a commit that referenced this issue Apr 3, 2022
supermerill added a commit that referenced this issue Apr 3, 2022
@dingyifei
Copy link
Author

so, with / the root directory inside the appimage archive, I have to copy my (current) /SuperSlicer.png to /usr/share/icons/hicolor/192x192/apps/SuperSlicer.png ?

I suspect that would fix it, when I was comparing the lycheeslicer appimage with superslicer's, the .desktop is similar.

@bassamanator
Copy link

@supermerill Post a test-fix here and I'll try it out and report back the results.

supermerill added a commit that referenced this issue Apr 4, 2022
@supermerill
Copy link
Owner

@bassamanator
Copy link

@supermerill I tried SuperSlicer-gtk3.AppImage. Icon is now showing on my system.

supermerill added a commit that referenced this issue Apr 15, 2022
@dingyifei
Copy link
Author

Seems to be partially solved, icon appear correctly now
but when it starts, it shows a separate thing in the taskbar

image

@bassamanator
Copy link

Seems to be partially solved, icon appear correctly now but when it starts, it shows a separate thing in the taskbar

Does this separate thing disappear? That separate thing is likely an hourglass animation.

@dingyifei
Copy link
Author

Seems to be partially solved, icon appear correctly now but when it starts, it shows a separate thing in the taskbar

Does this separate thing disappear? That separate thing is likely an hourglass animation.

It disappear when it's closed, but not when it's running

@bassamanator
Copy link

It disappear when it's closed, but not when it's running

I see. I can't imagine this having anything to do with SuperSlicer's appimage icon in particular.

@dingyifei
Copy link
Author

It disappear when it's closed, but not when it's running

I see. I can't imagine this having anything to do with SuperSlicer's appimage icon in particular.

I think it's an issue related to superslicer's appimage setup, maybe I should open another issue?

@bassamanator
Copy link

@dingyifei I'd be curious to see how other Appimages are working on your computer. Could you maybe assign the SS icon to a different appimage on your machine and see what happens when you start the app?

@supermerill
Copy link
Owner

i'll close because i can't reproduce. If it's disapearing agin, fell free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone can do the work and submit a pull request? problem ubuntu
Projects
None yet
Development

No branches or pull requests

3 participants