Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to insert Markdown directly (not via Path) #91

Open
undo76 opened this issue Jan 28, 2025 · 0 comments · May be fixed by #96
Open

Add ability to insert Markdown directly (not via Path) #91

undo76 opened this issue Jan 28, 2025 · 0 comments · May be fixed by #96
Assignees
@ThomasDelsart

Comments

@undo76
Copy link
Contributor

undo76 commented Jan 28, 2025 •
edited
Loading

The current implementation of insert_document is quite limiting and doesn't support several use cases:

  • Reading the documents from a CSV file
  • Reading the documents from a URL

Both cases force you to save the content into a temporary file before ingestion. It is not straightforward how to allow other inputs while preserving backwards compatibility as the markdown conversion is currently done inside this method and relies on the file extension.
@sinopeus sinopeus changed the title insert_document only allows Path as input Add ability to insert Markdown directly (not via Path) Feb 17, 2025
@ThomasDelsart ThomasDelsart linked a pull request Feb 17, 2025 that will close this issue
feat: Add functionality to incorporate directly markdown content (as string) when inserting documents #96
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasDelsart ThomasDelsart

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@undo76 @ThomasDelsart