fix: return reply on healthcheck (#833)

Author: fenos

src/http/routes/admin/tenants.ts

@@ -578,7 +578,7 @@ export default async function routes(fastify: FastifyInstance) {
         tenantId,
         upToMigration: dbMigrationFreezeAt,
       })
-      reply.send({
+      return reply.send({
         migrated: true,
       })
     } catch (e) {
@@ -668,12 +668,12 @@ export default async function routes(fastify: FastifyInstance) {
     fastify.get<tenantRequestInterface>('/:tenantId/health', async (req, res) => {
       try {
         await req.storage.healthcheck()
-        res.send({ healthy: true })
+        return res.send({ healthy: true })
       } catch (e) {
         if (e instanceof Error) {
           req.executionError = e
         }
-        res.send({ healthy: false })
+        return res.send({ healthy: false })
       }
     })
   })

src/http/routes/health/healthcheck.ts

@@ -13,12 +13,12 @@ export default async function routes(fastify: FastifyInstance) {
     async (req, res) => {
       try {
         await req.storage.healthcheck()
-        res.send({ healthy: true })
+        return res.send({ healthy: true })
       } catch (e) {
         if (e instanceof Error) {
           req.executionError = e
         }
-        res.send({ healthy: false })
+        return res.send({ healthy: false })
       }
     }
   )

src/internal/database/migrations/migrate.ts

@@ -11,7 +11,7 @@ import { getTenantConfig, TenantMigrationStatus } from '../tenant'
 import { multitenantKnex } from '../multitenant-db'
 import { ProgressiveMigrations } from './progressive'
 import { ResetMigrationsOnTenant, RunMigrationsOnTenants } from '@storage/events'
-import { ERRORS, StorageBackendError } from '@internal/errors'
+import { ERRORS } from '@internal/errors'
 import { DBMigration } from './types'
 import { getSslSettings } from '../ssl'
 import { MigrationTransformer, DisableConcurrentIndexTransformer } from './transformers'
@@ -699,11 +699,19 @@ function runMigrations({
             `Migration failed. Reason: ${(e as Error).message}`,
             e as MigrationError
           ).withMetadata({
-            migrationsToRun: migrationsToRun,
+            currentMigrations: appliedMigrations.map((migration) => ({
+              id: migration.id,
+              name: migration.name,
+              hash: migration.hash,
+            })),
+            migrationsToRun: migrationsToRun.map((migration) => ({
+              id: migration.id,
+              name: migration.name,
+              hash: migration.hash,
+            })),
             migrationId: migration.id,
             migrationName: migration.name,
             migrationHash: migration.hash,
-            migrationSql: migration.sql,
           })
         }
       }