Skip to content

data.id (still) missing for data return type / upload function #198

Open
@mikelieser

Description

@mikelieser

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

I get a type error after uploading a file, as "id" is not defined in current version 2.5.5 return data type for the upload function.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  • use current supabase/storage-js version 2.5.5 and TypeScript.
  • use this code
const { data } = await supabase.storage
      .from("bucket_name")
      .upload(
        `filename`,
        fileData
      );
    if (data) {
      const fileId = data.id; // <<< Property 'id' does not exist on type '{ path: string; }'.ts(2339)
    }

Result: Property 'id' does not exist on type '{ path: string; }'.ts(2339)

Expected behavior

  • no type error while accessing .id as the type is correctly defined.

Screenshots

version 2.5.5 type definition

Bildschirmfoto 2024-04-24 um 10 41 02

v2.5.5 code (latest version)
https://github.com/supabase/storage-js/blob/v2.5.5/src/packages/StorageFileApi.ts#L141

main code:
https://github.com/supabase/storage-js/blob/main/src/packages/StorageFileApi.ts#L142

It looks like something did not work as planned as there are commits fixing the upload return type:
https://github.com/supabase/storage-js/commits/v2.5.5

in main the code is fine since this commit Dec 19 2023:
68a6197

So I guess you just need to release v2.5.6 to fix it again 😄 Thanks.

System information

  • OS: macOS 14.4.1
  • Browser (if applies) [e.g. chrome, safari]
  • Version of supabase-js: 2.42.5
  • Version of @supabase/storage-js: 2.5.5
  • Version of Node.js: 20.11.0

Additional context

Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions