Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize validation of NodeIdInstance #277

Open
olirice opened this issue Dec 7, 2022 · 0 comments
Open

Standardize validation of NodeIdInstance #277

olirice opened this issue Dec 7, 2022 · 0 comments
Assignees
@olirice
Labels
enhancement New feature or request

Comments

@olirice
Copy link
Contributor

olirice commented Dec 7, 2022 •
edited

Describe the enhancement
Validation of NodeIdInstance has two components

  1. Does the user provided string have the correct components / shape?
  2. Does the schema/table/column-values combination match the table in the current context?

The implementation of 1 is centralized but the implementation of 2 is duplicated & you have to remember to do it when adding new nodeId fields
@olirice olirice added the enhancement New feature or request label Dec 7, 2022
@olirice olirice self-assigned this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olirice olirice

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olirice