From 26a6bf642f34e19e41a43112c92278d35dd4a241 Mon Sep 17 00:00:00 2001
From: Oliver Rice <github@oliverrice.com>
Date: Mon, 3 Feb 2025 09:06:37 -0600
Subject: [PATCH] allow platform specific diffs in error message

---
 test/expected/resolve_error_from_parser.out | 25 ++++++++++++++-------
 test/expected/test_error_parsing.out        |  8 -------
 test/sql/resolve_error_from_parser.sql      | 20 ++++++++++++-----
 test/sql/test_error_parsing.sql             |  3 ---
 4 files changed, 32 insertions(+), 24 deletions(-)
 delete mode 100644 test/expected/test_error_parsing.out
 delete mode 100644 test/sql/test_error_parsing.sql

diff --git a/test/expected/resolve_error_from_parser.out b/test/expected/resolve_error_from_parser.out
index aa63d852..b335260c 100644
--- a/test/expected/resolve_error_from_parser.out
+++ b/test/expected/resolve_error_from_parser.out
@@ -1,11 +1,20 @@
-select graphql.resolve($$
-{ { {
-    shouldFail
+-- Platform specific diffs so we have to test the properties here rather than exact response
+with d(val) as (
+  select graphql.resolve($$
+  { { {
+      shouldFail
+    }
   }
-}
-$$);
-                                                      resolve                                                      
--------------------------------------------------------------------------------------------------------------------
- {"errors": [{"message": "query parse error: Parse error at 2:3\nUnexpected `{[Punctuator]`\nExpected `Name`\n"}]}
+  $$)::json
+)
+select
+  (
+    json_typeof(val -> 'errors') = 'array'
+    and json_array_length(val -> 'errors') = 1
+  ) as is_valid
+from d;
+ is_valid 
+----------
+ t
 (1 row)
 
diff --git a/test/expected/test_error_parsing.out b/test/expected/test_error_parsing.out
deleted file mode 100644
index b6ddbe9b..00000000
--- a/test/expected/test_error_parsing.out
+++ /dev/null
@@ -1,8 +0,0 @@
-select graphql.resolve(
-    'query MyQuery { { extra brack }'
-)
-                                                      resolve                                                       
---------------------------------------------------------------------------------------------------------------------
- {"errors": [{"message": "query parse error: Parse error at 1:17\nUnexpected `{[Punctuator]`\nExpected `Name`\n"}]}
-(1 row)
-
diff --git a/test/sql/resolve_error_from_parser.sql b/test/sql/resolve_error_from_parser.sql
index f6fad57d..c45b02ee 100644
--- a/test/sql/resolve_error_from_parser.sql
+++ b/test/sql/resolve_error_from_parser.sql
@@ -1,6 +1,16 @@
-select graphql.resolve($$
-{ { {
-    shouldFail
+-- Platform specific diffs so we have to test the properties here rather than exact response
+with d(val) as (
+  select graphql.resolve($$
+  { { {
+      shouldFail
+    }
   }
-}
-$$);
+  $$)::json
+)
+
+select
+  (
+    json_typeof(val -> 'errors') = 'array'
+    and json_array_length(val -> 'errors') = 1
+  ) as is_valid
+from d;
diff --git a/test/sql/test_error_parsing.sql b/test/sql/test_error_parsing.sql
deleted file mode 100644
index 02d5034f..00000000
--- a/test/sql/test_error_parsing.sql
+++ /dev/null
@@ -1,3 +0,0 @@
-select graphql.resolve(
-    'query MyQuery { { extra brack }'
-)