Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for deno.jsonc #475

Open
maximilian-hammerl opened this issue Jan 17, 2025 · 4 comments
Open

Support for deno.jsonc #475

maximilian-hammerl opened this issue Jan 17, 2025 · 4 comments
Labels
C-feature Category: feature request E-easy
Milestone

Comments

@maximilian-hammerl
Copy link

Is your feature request related to a problem? Please describe.

An incorrect part of the Supabase documentation mentioned, that the edge functions support deno.jsonc files which they, it turns out, do not support: supabase/cli#3050

Therefore, I want to request support for deno.jsonc as a new feature for the edge runtime.

Describe the solution you'd like

Similar to how Deno already supports deno.jsonc files, it would be helpful if the Supabase edge functions also supported JSONC-specific features such as line and block comments.

@maximilian-hammerl maximilian-hammerl added the C-bug Category: something isn't working label Jan 17, 2025
@nyannyacha nyannyacha added P-low Low priority C-feature Category: feature request E-unknown and removed C-bug Category: something isn't working labels Jan 22, 2025
@sweatybridge
Copy link

@nyannyacha @laktek can we prioritise this? Currently CLI is working around this by parsing and removing comments client side before bundling. It's really not ideal imo https://github.com/supabase/cli/pull/3123/files#diff-001aaa0a0954e58661823757bfdf9ec9484ca6665ad195ce805a388287982c14R139

@laktek
Copy link
Contributor

laktek commented Feb 11, 2025

We will do this as part of Deno 2.1 milestone.

@nyannyacha nyannyacha added this to the Deno 2.1 LTS milestone Feb 11, 2025
@nyannyacha nyannyacha added E-easy and removed P-low Low priority E-unknown labels Feb 11, 2025
Copy link

linear bot commented Feb 11, 2025

Copy link
Contributor

nyannyacha commented Feb 11, 2025

Mark as Done. (I'll close this when the 2.1 upgrade PR is merged.)

We can now be loaded with deno.jsonc.

It was already confirmed to work during the integration test validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature request E-easy
Projects
None yet
Development

No branches or pull requests

4 participants