New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't download files on import of thermal module #182

Open

samaloney opened this issue Jan 30, 2025 · 0 comments

Labels

Bug

Collaborator

samaloney commented Jan 30, 2025 •

edited

Loading

sunkit-spex/sunkit_spex/models/physical/thermal.py

Lines 193 to 197 in a869fd4

    
           # Read line, continuum and abundance data into global variables. 
        
           CONTINUUM_GRID = setup_continuum_parameters() 
        
           LINE_GRID = setup_line_parameters() 
        
           DEFAULT_ABUNDANCES = setup_default_abundances() 
        
           DEFAULT_ABUNDANCE_TYPE = "sun_coronal_ext"

So maybe these should be set to None and then in the code which needs them check if None and call the methods or something

samaloney added the Bug label

samaloney changed the title ~~Don't download file etc on import of thermal models~~ Don't download files on import of thermal module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment